From: Kirill A. Korinsky <kirill@korins.ky>
Subject: Re: [PATCH] maintainer update www/unit to 1.34.2
To: osa@freebsd.org, ports@openbsd.org
Date: Tue, 22 Apr 2025 00:44:30 +0200

On Mon, 21 Apr 2025 15:24:19 +0200,
Kirill A. Korinsky <kirill@korins.ky> wrote:
> 
> On Mon, 03 Mar 2025 21:41:45 +0100,
> "Sergey A. Osokin" <osa@freebsd.org> wrote:
> > 
> > [1  <text/plain; utf-8 (7bit)>]
> > Hi,
> > 
> > could you please review and commit the changes from the
> > attached diff.
> > Thank you in advance.
> >
> 
> Have tried on arm64, make tests complains as:
> 
> ===>  Regression tests for unit-1.34.2
> cp /usr/local/lib/unit/modules/* /build/pobj/unit-1.34.2/unit-1.34.2/build/
> which: go: Command not found.
> which: go: Command not found.
> ...
> =================================== FAILURES ===================================
> ____________________________ test_tls_sni_same_alt _____________________________
> ...
> test/test_tls_sni.py:260: 
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
> test/test_tls_sni.py:54: in config_bundles
>     subprocess.check_output(
> /usr/local/lib/python3.12/subprocess.py:468: in check_output
>     return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
> 
> input = None, capture_output = False, timeout = None, check = True
> popenargs = (['openssl', 'req', '-new', '-subj', '/CN=subj1/', '-config', ...],)
> kwargs = {'stderr': -2, 'stdout': -1}
> process = <Popen: returncode: 1 args: ['openssl', 'req', '-new', '-subj', '/CN=subj1/'...>
> stdout = b"Error Loading request extension section myca_req_extensions\n25292723544:error:22FFF077:X509 V3 routines:CRYPTO_inte...:CRYPTO_internal:error in extension:/usr/src/lib/libcrypto/x509/x509_conf.c:96:name=subjectAltName, value=@alt_names\n"
> stderr = None, retcode = 1
> ...
>             retcode = process.poll()
>             if check and retcode:
> >               raise CalledProcessError(retcode, process.args,
>                                          output=stdout, stderr=stderr)
> E               subprocess.CalledProcessError: Command '['openssl', 'req', '-new', '-subj', '/CN=subj1/', '-config', '/tmp/unit-test-uq82i22w/openssl.conf', '-out', '/tmp/unit-test-uq82i22w/localhost.csr', '-keyout', '/tmp/unit-test-uq82i22w/localhost.key']' returned non-zero exit status 1.
> 
> /usr/local/lib/python3.12/subprocess.py:573: CalledProcessError
> --------------------------- Captured stdout teardown ---------------------------
> Path to unit.log:
> /tmp/unit-test-uq82i22w/unit.log
> 

I did future investigation.

1. until we have unit-go port, go dependency is useless.

2. it is a bug in tests: https://github.com/nginx/unit/pull/1599

both are irrelevant for update, and I had commited it.

-- 
wbr, Kirill