From: Stuart Henderson <stu@spacehopper.org>
Subject: Re: [Update from Maintainer] games/freeorion 0.5.1
To: Theo Buehler <tb@theobuehler.org>, Tom Murphy <openbsd@pertho.net>
Cc: <ports@openbsd.org>
Date: Wed, 30 Apr 2025 07:39:36 +0100

yes, let's go with the update, better warnings than BROKEN if it does 
actually run.

-- 
  Sent from a phone, apologies for poor formatting.

On 30 April 2025 06:54:03 Theo Buehler <tb@theobuehler.org> wrote:

> On Sat, Apr 19, 2025 at 12:40:47PM +0100, Tom Murphy wrote:
>> Hi Stuart,
>>
>> On Fri, Feb 28, 2025 at 06:09:56PM +0000, Stuart Henderson wrote:
>> > On 2025/02/28 17:22, Tom Murphy wrote:
>> > > Hi,
>> > >
>> > >   Attached is a patch to update games/freeorion to 0.5.1. I
>> > > tested it and it runs, but I am seeing this message:
>> >
>> > this could do with disabling:
>> >
>> > fatal: not a git repository (or any parent up to mount point /usr)
>> > Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
>> > WARNING: git not installed or not setup correctly
>> > WARNING: Can't determine git commit!
>> >
>> > > freeorion:/usr/local/lib/libboost_log-mt.so.23.0: freeorion :
>> > > WARNING: symbol(_ZTINSt3__19allocatorIvEE) size mismatch,
>> > > relink your program
>> >
>> > I think you'll need someone who knows their way around C++ to help here.
>> >
>> > What I can tell you which is probably relevant is that this is a weak
>> > symbol in some of freeorion's object files, and it's also a weak symbol
>> > in boost's libboost_log-mt.so.23.0.
>> >
>> > build-amd64/CMakeFiles/freeoriond.dir/server/ServerApp.cpp.o: 00000000 W 
>> _ZTINSt3__19allocatorIvEE
>> > build-amd64/CMakeFiles/freeoriond.dir/server/ServerFSM.cpp.o: 00000000 W 
>> _ZTINSt3__19allocatorIvEE
>> > build-amd64/CMakeFiles/freeoriond.dir/server/ServerNetworking.cpp.o: 
>> 00000000 W _ZTINSt3__19allocatorIvEE
>> > build-amd64/CMakeFiles/freeorionca.dir/client/ClientNetworking.cpp.o: 
>> 00000000 W _ZTINSt3__19allocatorIvEE
>> > build-amd64/CMakeFiles/freeorion.dir/client/ClientNetworking.cpp.o: 
>> 00000000 W _ZTINSt3__19allocatorIvEE
>> > build-amd64/freeorionca: 002eb4e0 W _ZTINSt3__19allocatorIvEE
>> > build-amd64/freeoriond: 00492e60 W _ZTINSt3__19allocatorIvEE
>> > build-amd64/freeorion: 008e4c70 W _ZTINSt3__19allocatorIvEE
>> >
>> > libboost_log-mt.so.23.0: 000c4840 W _ZTINSt3__19allocatorIvEE
>> > libboost_log.so.23.0: 000b6830 W _ZTINSt3__19allocatorIvEE
>> >
>> > $ llvm-cxxfilt-19 _ZTINSt3__19allocatorIvEE
>> > typeinfo for std::__1::allocator<void>
>
> May have to do with different ingredients being compiled with different
> -std=gnu++XX. std::__1::allocator<void> was deprecated in C++17 and
> removed in C++20.
>
> Anyway. The port doesn't build now since I landed the boost 1.87 update.
> I'm inclined to land this update and live with this for now since
> apparently it works for Tom.
>
> The other option would be to mark the port broken.
>
> Any preferences?