From: Mikolaj Kucharski <mikolaj@kucharski.name>
Subject: Re: NEW: ansible-runner 2.4.1
To: Caspar Schutijser <caspar@schutijser.com>
Cc: ports@openbsd.org
Date: Sat, 12 Jul 2025 18:27:41 +0000

Hi Caspar.

Thanks for review. Attached port updated.

- dropped PERMIT_DISTFILES
- modified patch-pyproject_toml patch, simplified dependency requirements


On Thu, Jul 10, 2025 at 06:26:13PM +0200, Caspar Schutijser wrote:
> Hi,
> 
> A couple of things:
> 
> > # Apache 2.0
> > PERMIT_PACKAGE =        Yes
> > PERMIT_DISTFILES =      Yes
> 
> bsd.port.mk(5) says:
> "If PERMIT_PACKAGE is set to ‘Yes’, PERMIT_DISTFILES will default
> to ‘Yes’.". So you can remove PERMIT_DISTFILES = Yes.
> 
> Additionally:
> 
> > $ cat patches/patch-pyproject_toml
> > - bump deps to what is in the tree
> > 
> > Index: pyproject.toml
> > --- pyproject.toml.orig
> > +++ pyproject.toml
> > @@ -1,5 +1,5 @@
> >  [build-system]
> > -requires = ["setuptools>=45, <=70.0.0", "setuptools-scm[toml]>=6.2, <=8.1.0"]  # pin max versions of build deps and update as needed
> > +requires = ["setuptools>=45, <=79.0.1", "setuptools-scm[toml]>=6.2, <=8.3.1"]  # pin max versions of build deps and update as needed
> 
> That looks like it will cause some pain when updating ports related to
> setuptools. By grepping on '\+requires' in the ports tree, I found
> some patches that do
> (for example, multimedia/py-chromecast/patches/patch-pyproject_toml):
> -requires = ["setuptools~=65.6", "wheel~=0.37.1"]
> +requires = ["setuptools", "wheel"]
> 
> Is that something we prefer in the ports tree? To me this looks like
> a nicer approach (if a setuptools update just works, it won't require
> adjusting this patch; if it does not work, we immediately see how this
> port fails to build).
> 
> Caspar
> 
> 
> On Tue, Jul 08, 2025 at 12:34:26PM +0000, Mikolaj Kucharski wrote:
> > Kind reminder.
> > 
> > On Wed, Jun 18, 2025 at 05:27:14PM +0000, Mikolaj Kucharski wrote:
> > > On Wed, May 28, 2025 at 11:21:34AM +0000, Mikolaj Kucharski wrote:
> > > > Hi.
> > > > 
> > > > Comment:
> > > > interface for controlling and interacting with Ansible
> > > > 
> > > > Description:
> > > > Ansible Runner is a tool and Python library that helps when
> > > > interfacing with Ansible directly or as part of another system whether
> > > > that be through a container image interface, as a standalone tool, or
> > > > as a Python module that can be imported. The goal is to provide a
> > > > stable and consistent interface abstraction to Ansible.
> > > > 
> > > > Please review. It works here.
> > > 
> > > Port re-attached.
> > 

-- 
Regards,
 Mikolaj