From: Stuart Henderson <stu@spacehopper.org>
Subject: Re: New ports: x11/qtile x11/py-dbus-next x11/py-xcffib x11/qtile-extras
To: Emiel Kollof <emiel@kollof.nl>
Cc: ports@openbsd.org
Date: Thu, 31 Jul 2025 13:27:33 +0100

On 2025/07/31 14:15, Emiel Kollof wrote:
> Stuart Henderson schreef op 2025-07-31 14:07:
> > On 2025/07/31 14:04, Emiel Kollof wrote:
> > > Stuart Henderson schreef op 2025-07-31 13:47:
> > > > Haven't looked at the tars yet, but the description didn't explain
> > > > what this does
> > > 
> > > It's a port for the qtile window manager (and dependencies that are
> > > not
> > > in ports yet. See the github link or https://qtile.org/
> > > 
> > > Cheers,
> > > Emiel
> > > 
> > 
> > The pkg/DESCR file needs to say what it does.
> 
> Attached new tarball with fixed description:
> 
> $ cat x11/qtile/pkg/DESCR
> A hackable tiling window manager written in Python
> 
> Qtile is simple, small, and extensible. It's easy to write your own layouts,
> widgets, and built-in commands.
> 
> Qtile is written and configured entirely in Python, which means you can
> leverage the full power and flexibility of the language to make it fit your
> needs.
> 
> Cheers,
> Emiel

Some other comments after reading the files;

- MODPY_EGG_VERSION changed to MODPY_DISTV (regen PLISTs after changing)

- MASTER_SITES changed to SITES before 7.4, but this should not be set
anyway if you have MODPY_PI=Yes

- MODPY_PI_DIR is unchanged from the default so should be dropped

- We stopped using flavours for Python ports before 7.7, remove
FLAVORS/FLAVOR/MODPY_FLAVOR

- MODPY_PYBUILD=hatchling or poetry-core alongside a BUILD_DEPENDS on
py-setuptools seems wrong

- for the ffi.dlopen patch, you should be able to just drop the .0,
I don't think you need to use ctypes.util.find_library here (and
find_library is implemented poorly for OpenBSD, so best avoided)

- USE_GNOME is only available if you use MODULES=x11/gnome, but you
probably don't want that here; a LIB_DEPENDS would be more appropriate

- LIB_DEPENDS is invalid unless there's a WANTLIB coming from that library.
since this uses dlopen rather than providing compiled code linking to
the library, it will show as 'extra' in make port-lib-depends-check',
so there should be a comment explaining why; e.g.

# uses dlopen()
WANTLIB += gobject-1.0 pango-1.0 pangocairo-1.0