From: Stuart Henderson <stu@spacehopper.org>
Subject: Re: New ports: x11/qtile x11/py-dbus-next x11/py-xcffib x11/qtile-extras
To: Emiel Kollof <emiel@kollof.nl>
Cc: ports@openbsd.org
Date: Thu, 31 Jul 2025 15:42:48 +0100

On 2025/07/31 15:22, Emiel Kollof wrote:
> Stuart Henderson schreef op 2025-07-31 14:27:
> 
> > Some other comments after reading the files;
> > 
> > - MODPY_EGG_VERSION changed to MODPY_DISTV (regen PLISTs after changing)
> > 
> > - MASTER_SITES changed to SITES before 7.4, but this should not be set
> > anyway if you have MODPY_PI=Yes
> > 
> > - MODPY_PI_DIR is unchanged from the default so should be dropped
> > 
> > - We stopped using flavours for Python ports before 7.7, remove
> > FLAVORS/FLAVOR/MODPY_FLAVOR
> > 
> > - MODPY_PYBUILD=hatchling or poetry-core alongside a BUILD_DEPENDS on
> > py-setuptools seems wrong
> 
> Fixed.
> 
> > - for the ffi.dlopen patch, you should be able to just drop the .0,
> > I don't think you need to use ctypes.util.find_library here (and
> > find_library is implemented poorly for OpenBSD, so best avoided)
> 
> This is the patch that went upstream and was accepted by the
> maintainer. This will go away when the next release drops.
> 
> Also, it seems to work on the two systems I've tried this on.

On OpenBSD, ctypes.util.find_library calls ldconfig -r and parses the
output to decide which library name to use. It works as long as the cache
(ld.so.hints) is up to date, but it's way more complex (and more racy)
than just passing e library name (without version) to dlopen().

> > - USE_GNOME is only available if you use MODULES=x11/gnome, but you
> > probably don't want that here; a LIB_DEPENDS would be more appropriate
> > 
> > - LIB_DEPENDS is invalid unless there's a WANTLIB coming from that
> > library.
> > since this uses dlopen rather than providing compiled code linking to
> > the library, it will show as 'extra' in make port-lib-depends-check',
> > so there should be a comment explaining why; e.g.
> > 
> > # uses dlopen()
> > WANTLIB += gobject-1.0 pango-1.0 pangocairo-1.0
> 
> Also fixed.
> 
> New tarball attached.

Thanks, will take a look when I have time.