From: yaydn@protonmail.com Subject: Re: new(ish) devel/sdl3 To: Thomas Frohwein Cc: "ports@openbsd.org" , "op@omarpolo.com" Date: Sun, 03 Aug 2025 06:00:02 +0000 På lørdag 2. august 2025 kl. 11:04, Thomas Frohwein skrev: > On Fri, 01 Aug 2025 23:46:38 +0200 > "Omar Polo" op@omarpolo.com wrote: > > > yaydn@protonmail.com wrote: > > > > > På fredag 1. august 2025 kl. 17:36, Omar Polo > > > op@omarpolo.com skrev: > > > > > > Tested this version on current/amd64. Built and looks good. > > > > > > Think this is a typo: > > > > > > -DSDL_WAYLAND=OON \ > > > > > > 'OON' instead of 'ON'. It enabled even so. ¯\(ツ)/¯ > > > > > > Also for alphabetical order in LIB_DEPENDS, if important, would be: > > > > > > wayland/wayland \ > > > x11/xkbcommon > > > > > > I think. > > > > Thank you for the nits :) > > Your welcome. :D Thanks op@! > > Rafael also noticed that I forgot to regen the patches after updating > > the port. > > > > thfr: this is ok op@ to import if you want :))) > > > Thanks everyone, I will check this on Tuesday when I have time again > and then import or report back. > Some more testing on sdl3: First time: 2: 08/02/25 03:48:57: >>> Suite 'Subsystems': Passed 2: 08/02/25 03:48:57: Total Run runtime: 25.6 sec 2: ERROR: 08/02/25 03:48:57: Run Summary: Total=353 Passed=347 Failed=2 Skipped=4 2: ERROR: 08/02/25 03:48:57: >>> Run /w seed 'P9Z59EXW8JW5ICTR': Failed 2: 08/02/25 03:48:57: Harness input to repro failures: 2: 08/02/25 03:48:57: --seed P9Z59EXW8JW5ICTR --filter TestVirtualJoystick 2: 08/02/25 03:48:57: --seed P9Z59EXW8JW5ICTR --filter stdlib_snprintf 2: 08/02/25 03:48:57: Exit code: 1 Second time: 22: 08/02/25 03:50:42: Total Run runtime: 17.9 sec 22: ERROR: 08/02/25 03:50:42: Run Summary: Total=353 Passed=340 Failed=2 Skipped=11 22: ERROR: 08/02/25 03:50:42: >>> Run /w seed '0PMSLPNRJ82GHUJB': Failed 22: 08/02/25 03:50:42: Harness input to repro failures: 22: 08/02/25 03:50:42: --seed 0PMSLPNRJ82GHUJB --filter TestVirtualJoystick 22: 08/02/25 03:50:42: --seed 0PMSLPNRJ82GHUJB --filter stdlib_snprintf 22: 08/02/25 03:50:42: Exit code: 1 Third time: 22: ERROR: 08/02/25 04:23:29: Run Summary: Total=353 Passed=340 Failed=2 Skipped=11 22: ERROR: 08/02/25 04:23:29: >>> Run /w seed '0NL9FMYVC5HRQPSK': Failed 22: 08/02/25 04:23:29: Harness input to repro failures: 22: 08/02/25 04:23:29: --seed 0NL9FMYVC5HRQPSK --filter TestVirtualJoystick 22: 08/02/25 04:23:29: --seed 0NL9FMYVC5HRQPSK --filter stdlib_snprintf 22: 08/02/25 04:23:29: Exit code: 1 Fourth time: 22: 08/03/25 01:55:25: Total Run runtime: 11.0 sec 22: ERROR: 08/03/25 01:55:25: Run Summary: Total=353 Passed=340 Failed=2 Skipped=11 22: ERROR: 08/03/25 01:55:25: >>> Run /w seed 'H4530GBSA49T5SUD': Failed 22: 08/03/25 01:55:25: Harness input to repro failures: 22: 08/03/25 01:55:25: --seed H4530GBSA49T5SUD --filter TestVirtualJoystick 22: 08/03/25 01:55:25: --seed H4530GBSA49T5SUD --filter stdlib_snprintf 22: 08/03/25 01:55:25: Exit code: 1 > FYI wayland was disabled based on sdl2 stuff and because I haven't been > setup to test it, and nobody else had requested it yet. I'm generally > happy to enable it and had plans to look into that eventually anyway. > > yaydn, feel free to test if you can add wayland support to sdl2 > similarly, I would appreciate the help with this. Awesome! I had actually been playing around with this to see if I could get mpv to use wayland natively. I was not sure of the guidance for sending it into ports, thank you for the clarification for these libraries. I'll do what I can. I am testing this now and building a few packages dependent on sdl2. Would I need to also bump all dependent packages or is testing all of dependant packages in ports sufficient?[0] As a novice to cvs, what should I be checking or doing to reduce regressions and hiccups? I want to be thorough, so sorry for the extra questions. Here is a draft: Index: Makefile =================================================================== RCS file: /cvs/ports/devel/sdl2/Makefile,v diff -u -p -u -p -r1.67 Makefile --- Makefile 17 May 2025 18:01:51 -0000 1.67 +++ Makefile 2 Aug 2025 17:36:01 -0000 @@ -1,6 +1,7 @@ COMMENT= cross-platform multimedia library V= 2.32.6 +REVISION= 0 DISTNAME= SDL2-${V} PKGNAME= sdl2-${V} @@ -19,12 +20,14 @@ DEBUG_PACKAGES= ${BUILD_PACKAGES} PERMIT_PACKAGE= Yes WANTLIB+= X11 Xcursor Xext Xfixes Xi Xrandr Xrender Xss iconv m pthread -WANTLIB+= samplerate sndio usbhid xcb +WANTLIB+= samplerate sndio usbhid xcb wayland-client wayland-cursor +WANTLIB+= wayland-egl # GL library is dlopen'd WANTLIB+= GL LIB_DEPENDS= audio/libsamplerate \ - converters/libiconv + converters/libiconv \ + wayland/wayland USE_GMAKE= Yes SEPARATE_BUILD= Yes @@ -43,7 +46,7 @@ CONFIGURE_ARGS+= --disable-alsa \ --disable-pipewire \ --disable-pulseaudio \ --disable-sndio-shared \ - --disable-video-wayland \ + --enable-video-wayland \ --disable-video-wayland-qt-touch \ --disable-wayland-shared \ --disable-x11-shared Index: pkg/PLIST =================================================================== RCS file: /cvs/ports/devel/sdl2/pkg/PLIST,v diff -u -p -u -p -r1.13 PLIST --- pkg/PLIST 18 Oct 2022 00:56:38 -0000 1.13 +++ pkg/PLIST 2 Aug 2025 17:36:01 -0000 @@ -78,7 +78,6 @@ include/SDL2/SDL_video.h include/SDL2/SDL_vulkan.h include/SDL2/begin_code.h include/SDL2/close_code.h -lib/cmake/ lib/cmake/SDL2/ lib/cmake/SDL2/sdl2-config-version.cmake lib/cmake/SDL2/sdl2-config.cmake @@ -90,6 +89,5 @@ lib/libSDL2_test.la @static-lib lib/libSDL2main.a lib/libSDL2main.la lib/pkgconfig/sdl2.pc -share/aclocal/ share/aclocal/sdl2.m4 share/doc/pkg-readmes/${PKGSTEM} -- Going to take nap. Thanks again! Have a good one and happy porting. Well wishes everyone. [0] Postscript: https://www.openbsd.org/faq/ports/guide.html#UpdateChecklist * Changes in existing dependencies generally do not affect a port version number. The package system uses a signature mechanism such that a binary package is fully identified by its package names, plus the dependencies against which it was built, plus the version numbers of all shared libraries it contains. So, if your port depends on a library, a change in that library's version number will trigger an update for packages built from your port. But, I want to make sure this sdl2 library change does not constitute a need for bumps.