From: Landry Breuil <landry@openbsd.org>
Subject: Re: wayland/wlroots : introduce mod_wlroots
To: ports@openbsd.org
Date: Thu, 14 Aug 2025 16:29:23 +0200

Le Wed, Aug 13, 2025 at 04:33:37PM +0200, Matthieu Herrb a écrit :
> On Tue, Aug 05, 2025 at 02:16:38PM +0200, Antoine Jacoutot wrote:
> > On Tue, Aug 05, 2025 at 02:12:28PM +0200, Antoine Jacoutot wrote:
> > > On Tue, Aug 05, 2025 at 01:53:11PM +0200, Matthieu Herrb wrote:
> > > > On Tue, Aug 05, 2025 at 12:47:32PM +0200, Landry Breuil wrote:
> > > > > Le Tue, Aug 05, 2025 at 12:33:33PM +0200, Matthieu Herrb a écrit :
> > > > > > On Tue, Aug 05, 2025 at 08:47:52AM +0200, Antoine Jacoutot wrote:
> > > > > > > On Tue, Aug 05, 2025 at 08:36:09AM +0200, Landry Breuil wrote:
> > > > > > Next iteration, with the variables names matching the module, and a
> > > > > > way to disable auto LIB_DEPENDS and WANTLIB to build the wlroot port
> > > > > > itself.
> > > > > 
> > > > > ok with the nit from sthen adressed (eg provide an intermediate var for
> > > > > potential subpackages needing MODWLROOTS_{WANTLIB,LIB_DEPENDS})
> > > > > 
> > > > 
> > > > Hopefully final version. I've not included diffs for depends ports
> > > > since they don't change.
> > > > 
> > > > ok?
> > > 
> > > Not quite.
> > > You have a typo in the MODULE.
> > > MODWLROOTS_LIB_DEPENDS versus MODWLROOT_LIB_DEPENDS (without the "S").
> > > Same for WANTLIB.
> > 
> > Also instead of using MODWLROOTS_LIBDEP=yes|no you could use:
> > .if ${.CURDIR:T} != wlroots
> > ...
> > .endif
> 
> In the future there may be ports with flavors or submodules that also
> won't need/want the default wantlib/lib_depends set. 
> > 
> > in the module.
> > 
> > And it needs an entry in port-modules(5).
> 
> New diff, rebased on -current with a ports-modules(5) diff and
> hopefully no more typos / thinkos.

still reads ok to me, thanks.