From: Stuart Cassoff <exokoide@yahoo.ca>
Subject: Re: tk 8.5 conflicts with tk 8.6 xorriso-tcltk
To: "Heppler, J. Scott" <shep971@spectrum.net>,  Stuart Henderson <stu@spacehopper.org>
Cc: "ports@openbsd.org" <ports@openbsd.org>
Date: Wed, 10 Sep 2025 14:33:21 +0000

Hi,

I've yet to try it with 8.6, though I see no reason not to give it a go.

There is a new version (1.5.6) that has no significant changes wrt Tcl/Tk.

Here's a patch/suggestion that fixes a couple of things.

--- /usr/ports//sysutils/libisoburn/Makefile    Thu Oct  5 10:53:18 2023
+++ ./Makefile  Wed Sep 10 10:14:18 2025
@@ -14,7 +14,7 @@
 
 CATEGORIES =   sysutils
 
-HOMEPAGE =     https://dev.lovelyhq.com/libburnia/web/wikis/Libisoburn
+HOMEPAGE =     https://dev.lovelyhq.com/libburnia/web/wiki/Libisoburn
 SITES =                http://files.libburnia-project.org/releases/
 
 # GPLv2+
@@ -27,7 +27,7 @@
 WANTLIB-main =         burn curses iconv isofs pthread readline z
 LIB_DEPENDS-xorriso =  ${BASE_PKGPATH},-main
 WANTLIB-xorriso =      ${WANTLIB-main} c isoburn
-RUN_DEPENDS-tcltk =    ${MODTCL_RUN_DEPENDS}
+RUN_DEPENDS-tcltk =    ${MODTK_RUN_DEPENDS}
 
 CONFIGURE_STYLE =      gnu
 CONFIGURE_ARGS =       --enable-pkg-check-modules
@@ -36,7 +36,7 @@
                        LDFLAGS="-L${LOCALBASE}/lib ${LDFLAGS}"
 
 post-patch:
-       perl -pi -e 's#/usr/bin/wish#${MODTK_BIN}#' ${WRKSRC}/frontend/xorriso-tcltk
-#      @${MODTCL_WISH_ADJ} ${WRKSRC}/frontend/xorriso-tcltk
+       # MODTCL_WISH_ADJ doesn't handle trailing space.
+       perl -pi -e '$$. == 1 && s#/usr/bin/wish #${MODTK_BIN}#' ${WRKSRC}/frontend/xorriso-tcltk
 
 .include <bsd.port.mk>



Stu


On Wednesday, September 10, 2025 at 03:52:05 a.m. EDT, Stuart Henderson <stu@spacehopper.org> wrote: 





cc'ing stu@ (maintainer for Tcl/Tk)

On 2025/09/09 14:54, Heppler, J. Scott wrote:
> The optical disk burner front end, xorriso-tcltk needs a tk shell
> providing /usr/local/bin/wish and the present Makefile lists
> Run dependencies

I don't see the conflict?

$ pkg_info|grep -e ^tk -e ^tcl
tcl-8.5.19p6        Tool Command Language
tcl-8.6.16          Tool Command Language
tk-8.5.19p2        graphical toolkit for Tcl
tk-8.6.16          graphical toolkit for Tcl

Our Tcl/Tk packages only provide binaries which include version numbers,
there's no package providing /usr/local/bin/wish, and other ports use
patches/sed/.. to set #! lines correctly. That's done for xorriso-tcltk:

$ head -1 /usr/local/bin/xorriso-tcltk 
#!/usr/local/bin/wish8.5 

>    tcl->=8.5,<8.6:lang/tcl/8.5
> 
> cad/opencascade is dependent on tcl/8.6
> 
> Would anyone have objections to upgrading the tcl/tk version to 8.6 in
> xorriso-tcltk?

unless there's a special reason for using a different Tcl/Tk version
(i.e. some software requires a newer or older version), the normal
approach in ports is to use the default version specified in
lang/tcl/tcl.port.mk / x11/tk/tk.port.mk. I wonder if we're anywhere
near flipping the default to 8.6 though..