From: Nam Nguyen <namn@messagemode2.com>
Subject: Re: update emulators/libchdr-1.0pl20250608
To: ports@openbsd.org
Date: Tue, 16 Sep 2025 18:01:46 -0700

Nam Nguyen writes:

ping. The diff is attached.

> Here is a diff for emulators/libchdr to update to a newer commit on
> 20250608. It is needed for a emulators/flycast I am sending after.
>
> This diff:
> - adds a minor bump
> - links with archivers/zstd instead of the newly bundled zstd
>
> huffman.h has a function that now returns enum huffman_error instead of
> void. But, this function seems to be mostly internal and is not used by
> consumers emulators/libretro-pcsx-rearmed and emulators/flycast. This
> does not necessitate a major bump. Whereas before the code in libchdr
> ignored the return value, it now uses the return value.
>
> $ diff -u /usr/obj/pobj/libchdr-1.0pl{20230220,20250608}/fake-amd64/usr/local/include/libchdr/huffman.h
> --- /usr/obj/pobj/libchdr-1.0pl20230220/fake-amd64/usr/local/include/libchdr/huffman.h  Mon Feb 20 06:24:40 2023
> +++ /usr/obj/pobj/libchdr-1.0pl20250608/fake-amd64/usr/local/include/libchdr/huffman.h  Wed Dec 11 03:28:49 2024
> @@ -85,6 +85,6 @@
>  enum huffman_error huffman_assign_canonical_codes(struct huffman_decoder* decoder);
>  enum huffman_error huffman_compute_tree_from_histo(struct huffman_decoder* decoder);
>  
> -void huffman_build_lookup_table(struct huffman_decoder* decoder);
> +enum huffman_error huffman_build_lookup_table(struct huffman_decoder* decoder);
>
>
> There are some new symbols so I propose a minor bump.
>
>   /usr/obj/pobj/libchdr-1.0pl20230220/fake-amd64/usr/local/lib/libchdr.so.1.0 --> /usr/obj/pobj/libchdr-1.0pl20250608/fake-amd64/usr/local/lib/libchdr.so.1.1
> Dynamic export changes:
> added:
>         chd_read_header_core_file
>         chd_read_header_file
>
> External reference changes:
> added:
>         ZSTD_trace_decompress_begin
>         ZSTD_trace_decompress_end
>         calloc
>         puts
>
>
> I tested all consumers opening chd files in
> emulators/libretro-pcsx-rearmed and emulators/flycast. I tested running
> some zstd compressed chd files and it works, now that libchdr added zstd
> support. chdman was used to compress some audio data using zstd when
> creating the chd files.
>
> I noticed that in retroarch for libretro-pcsx-rearmed, I had to use
> desktop program mode, which was known before. Also, the input menu for
> configuring controls was empty. My playstation 4 controller worked, but
> there were messages of using a "fallback method" for the controller.
>
> Feedback and tests are welcome. OK?