From: Marcus Glocker Subject: Re: NEW: sysutils/wmtempmon To: Rafael Sadowski Cc: ports@openbsd.org Date: Fri, 19 Sep 2025 22:38:15 +0200 On Fri, Sep 19, 2025 at 11:02:59AM +0200, Rafael Sadowski wrote: > On Thu Sep 18, 2025 at 06:43:28AM +0200, Marcus Glocker wrote: > > wmtempmon-0.1: > > > > wmtempmon is a wmdockapp which displays the temperature monitored by a > > temperature sensor. In the title you can see the temperature sensor > > name. In the main area you can see the current temperature measured by > > the monitored sensor. > > > > https://nazgul.ch/dev_wmtempmon.html > > > > OK? Thanks for your feedback. > Looks good, some tweaks: > > - I would remove "wm-dockapp; " from COMMENT Looking at the other wm-dockapp ports, we have 26 others which use the same pattern: # find . -name Makefile | xargs grep COMMENT | grep wm-dockapp | wc -l 26 Hence, at the moment I would prefer to stay consistent, and keep it. If we want to remove "wm-dockapp" from the COMMENT, I think we should do it for all the wm-dockapp ports. > - You may want to remove the CVS folder in pkg before import ;) Oh, sure. "Copy/paste" left over ;-) > - x11/windowmaker is not a category True. I'll switch it to sysutils. But also here, I think we could use some cleanup in general: # find . -name Makefile | xargs grep CATEGORIES | grep x11\/windowmaker | wc -l 36 > Otherwise OK rsadowski to import.