From: Daniel Jakots <danj@chown.me>
Subject: Re: [UPDATE] net/miniflux 2.2.12 -> 2.2.13
To: "Igor Zornik" <mocheryl@mocheryl.org>
Cc: "OpenBSD ports" <ports@openbsd.org>
Date: Thu, 2 Oct 2025 17:32:15 -0400

On Wed, 01 Oct 2025 19:04:46 +0200, "Igor Zornik"
<mocheryl@mocheryl.org> wrote:

> Hello, ports.
> 
> New version of miniflux brings fixes, features, database updates, and
> messed up tags again. I also reformatted the Makefile and added the
> missing homepage while I was at it. Building and running tested on
> yesterday's amd64 snap. QP-encoded diff for all below. Someone please
> commit if OK.

Hey Igor!

Looks good (with 2 minor details), but unfortunately the tree is now
locked. It will wait until the unlock, unless I'm missing something
that makes the update important?

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/net/miniflux/Makefile,v
> retrieving revision 1.25
> diff -u -p -u -p -r1.25 Makefile
> --- Makefile	27 Aug 2025 23:07:44 -0000	1.25
> +++ Makefile	1 Oct 2025 16:32:17 -0000
> @@ -1,25 +1,27 @@
>  COMMENT =	atom/rss feed reader web application
>  
> -V =		2.2.12
> +V =	2.2.13

not indented properly compared to the other lines :P

>  MODGO_MODNAME =	miniflux.app/v2
> -MODGO_VERSION =	v${V}
> +MODGO_VERSION =	v2.2.13-0.20250915235747-10b2b36895dd
>  
>  DISTNAME =	${MODGO_MODNAME}-${MODGO_VERSION}
>  PKGNAME =	miniflux-${V}
>  
>  CATEGORIES =	net www
>  
> +HOMEPAGE =	https://miniflux.app/
> +
>  MAINTAINER =	Igor Zornik <mocheryl@mocheryl.org>
>  
>  # Apache 2.0
>  PERMIT_PACKAGE =	Yes
>  
> -WANTLIB += c pthread
> +WANTLIB +=	c pthread

As a general rule, there shouldn't be any tab here because this line is
the output of
$ make port-lib-depends-check 

miniflux-2.2.13(net/miniflux):
Missing: c.102 (/usr/local/bin/miniflux) (system lib)
Missing: pthread.28 (/usr/local/bin/miniflux) (system lib)
WANTLIB += c pthread
*** Error 1 in target 'port-lib-depends-check' (ignored)

(I don't think the WANTLIB will change here, but since it applies to
all the ports, I think it makes sense to keep it that way).

Cheers,
Daniel