From: Matthieu Herrb <matthieu@openbsd.org>
Subject: Re: seatd: default to noop backedn
To: Landry Breuil <landry@openbsd.org>
Cc: ports@openbsd.org
Date: Sat, 4 Oct 2025 20:50:17 +0200

On Sat, Oct 04, 2025 at 07:39:07PM +0200, Landry Breuil wrote:
> hi,
> 
> instead of setting SEATD_BACKEND=noop in all wayland wrapper scripts,
> maybe we can have seatd default to it.. iirc i've tested this diff, but
> forgot to send it at the time..
> 
> testing/feedback from the wayland crowd welcome :)
> 
> Landry

Works here. ok matthieu@

BTW the patch comment is not 100% accurate, as the builtin backend
also works, although it requires to launch seatd -u <user> as root,
which is not user friendly and probably not safe until seatd is
properly pledged and unveiled (or replaced by a better wscons backend).


> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/sysutils/seatd/Makefile,v
> diff -u -r1.8 Makefile
> --- Makefile	3 Aug 2024 07:13:49 -0000	1.8
> +++ Makefile	17 Sep 2025 07:05:35 -0000
> @@ -3,7 +3,7 @@
>  V =		0.8.0
>  DISTNAME =	seatd-$V
>  CATEGORIES =	sysutils
> -REVISION =	0
> +REVISION =	1
>  
>  SITES =		https://git.sr.ht/~kennylevinsen/seatd/archive/
>  DISTFILES =     seatd-{}${V}${EXTRACT_SUFX}
> Index: patches/patch-libseat_libseat_c
> ===================================================================
> RCS file: patches/patch-libseat_libseat_c
> diff -N patches/patch-libseat_libseat_c
> --- /dev/null	1 Jan 1970 00:00:00 -0000
> +++ patches/patch-libseat_libseat_c	17 Sep 2025 07:05:35 -0000
> @@ -0,0 +1,14 @@
> +skip the builtin backend, so that we default to the noop backend
> +(the only one working on OpenBSD for now)
> +Index: libseat/libseat.c
> +--- libseat/libseat.c.orig
> ++++ libseat/libseat.c
> +@@ -65,7 +65,7 @@ struct libseat *libseat_open_seat(const struct libseat
> + 
> + 	struct libseat *backend = NULL;
> + 	for (const struct named_backend *iter = impls; iter->backend != NULL; iter++) {
> +-		if (iter->backend == &noop_impl) {
> ++		if (iter->backend == &builtin_impl) {
> + 			continue;
> + 		}
> + 		backend = iter->backend->open_seat(listener, data);


-- 
Matthieu Herrb