From: Antoine Jacoutot <ajacoutot@bsdfrog.org>
Subject: Re: unresolved symbols in textproc/link-grammar
To: Jonathan Gray <jsg@jsg.id.au>
Cc: ports@openbsd.org
Date: Fri, 17 Oct 2025 08:38:49 +0200

On Fri, Oct 17, 2025 at 11:04:29AM +1100, Jonathan Gray wrote:
> On Wed, Oct 15, 2025 at 03:23:18PM +0200, Antoine Jacoutot wrote:
> > On Thu, Oct 16, 2025 at 12:07:15AM +1100, Jonathan Gray wrote:
> > > Running link-parser on amd64, there was an undefined reference to call_once.
> > > This symbol comes from devel/libstdthreads.
> > > 
> > > Remove BROKEN-sparc64 as the symbols listed there are also found in
> > > libstdthreads.
> > 
> > Thank you!
> > OK aja post-unlock.
> 
> I missed WANTLIB/LIB_DEPENDS in the previous diff.

OK aja

> 
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/textproc/link-grammar/Makefile,v
> diff -u -p -r1.80 Makefile
> --- Makefile	30 Aug 2025 09:34:00 -0000	1.80
> +++ Makefile	16 Oct 2025 23:56:33 -0000
> @@ -1,5 +1,3 @@
> -BROKEN-sparc64 = Undefined references in liblink-grammar.so to mtx_lock, tss_set, and others
> -
>  ONLY_FOR_ARCHS-java =	i386 amd64
>  ONLY_FOR_ARCHS =	${CLANG_ARCHS} ${LLVM_ARCHS}
>  
> @@ -8,6 +6,7 @@ COMMENT-java =		Java bindings for link-g
>  COMMENT-python =	Python bindings for link-grammar
>  
>  VERSION =		5.12.6
> +REVISION =		0
>  DISTNAME =		link-grammar-${VERSION}
>  PKGNAME-main =		${DISTNAME}
>  PKGNAME-java =		link-grammar-java-${VERSION}
> @@ -23,7 +22,7 @@ HOMEPAGE =		https://opencog.github.io/li
>  # LGPLv2.1
>  PERMIT_PACKAGE =	Yes
>  
> -WANTLIB += curses hunspell-1.7 m pcre2-8 sqlite3 ${COMPILER_LIBCXX}
> +WANTLIB += curses hunspell-1.7 m pcre2-8 sqlite3 stdthreads ${COMPILER_LIBCXX}
>  
>  WANTLIB-main += ${WANTLIB} c perl pthread z
>  
> @@ -48,10 +47,10 @@ PSEUDO_FLAVORS =	no_java
>  
>  .include <bsd.port.arch.mk>
>  
> -BUILD_DEPENDS =		devel/libstdthreads \
> -			devel/swig
> +BUILD_DEPENDS =		devel/swig
>  
> -LIB_DEPENDS=		databases/sqlite3
> +LIB_DEPENDS=		databases/sqlite3 \
> +			devel/libstdthreads
>  
>  LIB_DEPENDS-main =	${LIB_DEPENDS} \
>  			devel/pcre2 \
> --- /dev/null	Fri Oct 17 10:58:37 2025
> +++ patches/patch-link-grammar_Makefile_am	Wed Oct 15 23:38:43 2025
> @@ -0,0 +1,13 @@
> +Index: link-grammar/Makefile.am
> +--- link-grammar/Makefile.am.orig
> ++++ link-grammar/Makefile.am
> +@@ -81,6 +81,9 @@ liblink_grammar_la_LIBADD  += ${PTHREAD_LIBS}
> + # It seems no mathematical function is used now. Keep it to be on the safe side.
> + liblink_grammar_la_LIBADD  += -lm
> + 
> ++# for call_once
> ++liblink_grammar_la_LIBADD  += -lstdthreads
> ++
> + if WITH_CXXREGEX
> + dict-common/regex-morph.lo: AM_CFLAGS = -x c++ $(CXXFLAGS) $(WARN_CXXFLAGS)
> + dict-common/regex-morph.lo: CFLAGS =
> 

-- 
Antoine