From: Theo Buehler <tb@theobuehler.org>
Subject: Re: cleanup/reorder cmake.port.mk
To: Rafael Sadowski <rafael@sizeofvoid.org>
Cc: ports@openbsd.org
Date: Fri, 24 Oct 2025 09:38:47 +0200

On Fri, Oct 24, 2025 at 07:11:51AM +0200, Rafael Sadowski wrote:
> Before we commit cmake4, I would like to have cmake.mk reviewed
> and committed separately.
> 
> 1. I would prefer not to have CMAKE_AUTOGEN_PARALLEL at the
>    beginning, all by itself, before the actual configure arguments
>    are set.

Sure.

> 2. Nothing uses "samurai". If anyone wants to use it, they can set
>    USE_NINJA=No and CONFIGURE_ARGS += -DCMAKE_MAKE_PROGRAM=samu
>    themselves. I don't want that in the module.
> 
> 2.1 Once "samurai" is gone, we can write the first if-else
>     cleanly. If Ninja otherwise ‘Unix Makefiles’ The second large
>     block is the one without else. This also makes it easier to read.

I don't really understand this. I don't see a massive improvement in
cleanliness or readability coming from dropping one .elif, one || and
two additional lines. I think a single port using samurai will have
to deal with more complexity than that.

Then again I don't feel strongly about having to support samu right now
and would also be fine with adding this logic back when samu is needed.