From: Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>
Subject: Re: MAINTAINER UPDATE security/routersploit
To: awolk@openbsd.org, stu@spacehopper.org
Cc: alf <a.schlichting@lemarit.com>, ports <ports@openbsd.org>
Date: Sat, 1 Nov 2025 17:08:33 +0100

Hi Stuart,

On Sat, Nov 1, 2025 at 1:16 PM Stuart Henderson <stu@spacehopper.org> wrote:

> On 2025/10/31 21:24, Sebastian Reitenbach wrote:
> > Hi,
> >
> > attached patch updates routersploit from 3.4.0 -> 3.4.7, and while there
> unbreaks its usage. It
> > requires the net/py-snmp update I just sent in previous mail.
> >
> > comments or even OK?
> >
> > Sebastian
>
> Looks like patches/patch-rsf_py is obsolete since
> https://github.com/threat9/routersploit/commit/c7ad64f117344b
> and the change to write logs in $HOME rather than cwd isn't ideal.
> Can this patch just be removed?
>

I had it in, as I'm a bit annoyed about log files left behind
whereever $CWD may be. But
I left it out.


>
> It uses pkg_resources at runtime, as of py3.12 this is not in python
> itself any more, moved to setuptools, so it needs RUN_DEPENDS on
> devel/py-setuptools.
>

added



>
> Whitespace in the Makefile got a bit messy after a ports-wide change so
> it would make sense to tidy that too when updating.
>

tiedied up, makes the patch a bit less readable :/


>
> Not a blocker for updating, but this will break when we move to Python
> 3.13 so it would be a good idea to preemptively port "standard-telnetlib"
> and add it as RUN_DEPENDS.
>

will look into it next.

It works well with your updated py-snmp to latest (probably a cut'n pasto
on my side
why I haven't updated to latest). With your latest version of py-snmp, I
can drop the
patch I introduced with the update as well, so even better.

Should attached now be OK?

thank you,
 Sebastian