From: Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>
Subject: Re: NEW: net/py-standard-telnetlib
To: Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>, ports <ports@openbsd.org>
Cc: stu@spacehopper.org
Date: Mon, 3 Nov 2025 18:29:21 +0100

On Mon, Nov 3, 2025 at 2:05 PM Stuart Henderson <stu@spacehopper.org> wrote:

> On 2025/11/02 22:14, Sebastian Reitenbach wrote:
> > ============================= test session starts
> ==============================
> > platform openbsd7 -- Python 3.12.11, pytest-8.4.2, pluggy-1.6.0
> > rootdir:
> /var/ports/pobj/amd64/py-standard-telnetlib-3.13.0/standard_telnetlib-3.13.0
> > configfile: pyproject.toml
> > plugins: anyio-4.9.0
> > collected 0 items / 1 error
> >            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > tests/test_telnetlib.py:6: in <module>
> >     from test import support
> > E   ModuleNotFoundError: No module named 'test'
>
> oh, that is  TEST_DEPENDS = lang/python/3,-tests
>
> (pkg_add python-tests%3)
>

Added TEST_DEPENDS
also tests worked, with proper PORTSDIR and issuing "make test" in the
proper directory.


>
> > because it picks up py3-anyio for testing, should it be added to
> TEST_DEPENDS ?
>
> pytest just lists all installed test plugins. please don't add those
> to TEST_DEPENDS unless the port uses it (standard-telnetlib doesn't).
>
> > I'll replace my test VM with latest snapshot, and retest again before
> importing.
>
> since I've now been adding some other py-standard-XX to help with my
> python 3.13 test build I've realised that they shouldn't be linked to
> the build until we actually switch. please import but leave unlinked
> and don't add the dep to routersploit yet, I'll stage it in my py313
> tree for committing when we're ready to move across. thanks :)
>

It's in now, but I left it unlinked.

cheers,
Sebastian