From: Landry Breuil <landry@openbsd.org>
Subject: Re: multimedia/handbrake: update to 1.10.2
To: ports@openbsd.org
Date: Wed, 12 Nov 2025 19:06:43 +0100

Le Wed, Nov 12, 2025 at 06:45:35PM +0100, Landry Breuil a écrit :
> Le Wed, Nov 12, 2025 at 06:37:47PM +0100, Landry Breuil a écrit :
> > Le Wed, Nov 12, 2025 at 05:15:09PM +0100, Kirill A. Korinsky a écrit :
> > > ports@,
> > > 
> > > I'd like to update multimedia/handbrake to 1.10.2
> > > 
> > > I had started with clean patches folders.
> > > 
> > > It builds, I had encoded a short test video.
> > > 
> > > Anyway, any tests are welcomes, and OKs.
> > 
> > I know this port has CONFIGURE_STYLE=simple, but...
> > 
> > > @@ -40,6 +39,8 @@ BUILD_DEPENDS =	devel/autoconf/${AUTOCON
> > >  		devel/automake/${AUTOMAKE_VERSION} \
> > >  		devel/gettext,-tools \
> > >  		devel/libtool \
> > > +		devel/meson \
> > > +		devel/ninja \
> > 
> > This feels... wrong.
> > 
> > can't we somehow make it directly use the meson module with
> > gtk/meson.build, instead of their homegrown horror of make/configure.py ?
> 
> bah, it first tries to build libghb (aptly naming ...) so it doesn't use
> meson all the way it seems.

so configure.py generates a GNUMakefile, which in turns after having
built libhb (which fails for me for now), should then calls meson via
the rules in https://github.com/HandBrake/HandBrake/blob/master/gtk/module.rules
... i don't really know what's best here.