From: Landry Breuil Subject: Re: multimedia/handbrake: update to 1.10.2 To: ports@openbsd.org Date: Wed, 12 Nov 2025 20:23:07 +0100 Le Wed, Nov 12, 2025 at 07:25:35PM +0100, Kirill A. Korinsky a écrit : > On Wed, 12 Nov 2025 19:19:04 +0100, > Kirill A. Korinsky wrote: > > > > On Wed, 12 Nov 2025 18:37:47 +0100, > > Landry Breuil wrote: > > > > > > Le Wed, Nov 12, 2025 at 05:15:09PM +0100, Kirill A. Korinsky a écrit : > > > > ports@, > > > > > > > > I'd like to update multimedia/handbrake to 1.10.2 > > > > > > > > I had started with clean patches folders. > > > > > > > > It builds, I had encoded a short test video. > > > > > > > > Anyway, any tests are welcomes, and OKs. > > > > > > I know this port has CONFIGURE_STYLE=simple, but... > > > > > > > @@ -40,6 +39,8 @@ BUILD_DEPENDS = devel/autoconf/${AUTOCON > > > > devel/automake/${AUTOMAKE_VERSION} \ > > > > devel/gettext,-tools \ > > > > devel/libtool \ > > > > + devel/meson \ > > > > + devel/ninja \ > > > > > > This feels... wrong. > > > > > > can't we somehow make it directly use the meson module with > > > gtk/meson.build, instead of their homegrown horror of make/configure.py ? > > > > > > > this homegrown horror creates GNUmakefile which compiles some dependencies, > > and after it's done it calls meson and after that ninja. > > > > Before it was autoconf and make, but they decided to migrate to meson. > > > > Here a bit cleaner diff where I nuke autotools, and it survived a build in > > clean chroot. And I also put comment which explains why meson/ninja here. > > > > ...and I forgot to add new patches. Here the right diff. seems it switched to Gtk+4 :) Run-time dependency gtk4 found: YES 4.20.2 Missing lib: gtk-4.5 (/usr/local/bin/ghb) (NOT REACHABLE) Extra: X11-xcb.2 X11.19 Xau.10 Xcomposite.4 Xcursor.5 Xdamage.4 Extra: Xdmcp.11 Xext.13 Xfixes.6 Xi.12 Xinerama.6 Xrandr.7 Extra: Xrender.6 aom.6 atk-1.0.21810 atk-bridge-2.0.0 atspi.1 Extra: bz2.10 cairo-gobject.2 cairo.13 crypto.57 dav1d.3 dbus-1.11 Extra: drm.7 epoll-shim.0 epoxy.4 execinfo.4 expat.17 ffi.2 Extra: fontconfig.14 freetype.31 fribidi.3 gdk-3.2201 gmodule-2.0.4200 Extra: graphite2.2 gsm.1 gstaudio-1.0.7 gstbase-1.0.7 gstpbutils-1.0.7 Extra: gstreamer-1.0.7 gsttag-1.0.7 gstvideo-1.0.7 gthread-2.0.4200 Extra: gtk-3.2201 harfbuzz.18 jpeg.71 lzma.2 mp3lame.2 opus.1 Extra: orc-0.4.7 pangocairo-1.0.3801 pangoft2-1.0.3801 pcre2-8.0 Extra: pixman-1.46 png.18 sharpyuv.0 speex.8 ssl.60 udfread.0 Extra: unibreak.1 va-drm.2 va-x11.2 va.2 vidstab.0 vpx.19 Extra: wayland-client.0 wayland-cursor.0 wayland-egl.0 webp.4 Extra: webpmux.2 xcb-dri3.0 xcb-render.1 xcb-shm.1 xcb.4 xkbcommon.4 Extra: xvidcore.5 z.7 zimg.0