From: Stuart Henderson Subject: Re: [new]: Ringdove EDA suite, successor to cad/geda-gaf To: Chris Billington Cc: ports@openbsd.org Date: Thu, 4 Dec 2025 14:05:29 +0000 some comments from reading the files in your tars, I've not tried building, don't have time for a full review and not particularly interested in this software myself. don't set do-build to just run make, or set do-configure to just run configure, that is normal behaviour "CONFIGURE_STYLE=none" was a hack for some things using MODULES=lang/python due to an issue with how python.port.mk used to work but shouldn't be used now. from reading the ports makefiles it looks like these should set to either "gnu" or "simple" depending on whether the scripts being run are gnu autoconf scripts or some other configure scripts various version numbers (lua, python, tcl) hardcoded should use variables from the relevant modules configure is only run once, you can't set CONFIGURE_ARGS per subpackage (can't remember if you fixed that in later versions or not) for which don't use C++, if you set COMPILER you should also set COMPILER_LANGS=c. (I'm not sure whether you need to set COMPILER or not for these). the various things with BUILD_DEPENDS and RUN_DEPENDS pointing at libraries makes me think there is some confusion around libraries which should normally use LIB_DEPENDS and have WANTLIB entries re the metapackages in the later tar; we don't split packages up to that extent. only reason I see for splitting camv-rnd would be if some of the plugins had different (and large) library dependencies to cut those down (as done in asterisk, php, etc) but I'm not seeing that here. COMMENT should starts lowercase except for proper nouns 'Sample configuration files are installed in [...]' - this is ports standard and doesn't warrant a MESSAGE i suspect "make port-lib-depends-check" will complain about quite a lot of things. there are various things setting variables to the default; in particular the multi packages things using PKGNAME-x - do "make show=PKGNAMES" as-is and with those lines removed/commented and compare; it should give the same in both cases. that then gets rid of uses of ${V} and then you would just write e.g. DISTNAME=fungw-1.2.2 rather than setting V. shared library version numbers start from 0.0 in ports. we don't do the linux symlinking thing for libraries (eg. in genht do-install).