From: Stuart Cassoff <exokoide@yahoo.ca>
Subject: tk.port.mk: Guard against version mismatches
To: OpenBSD Ports <ports@openbsd.org>
Date: Sat, 6 Dec 2025 08:32:08 -0500

Version mismatch happens if the wrong MOD_ var is set.


MODULES = x11/tk
MODTCL_VERSION = 8.6
# Should be MODTK_VERSION

$ make
Fatal: versions must be equal: MODTCL_VERSION=8.6, MODTK_VERSION=8.5. (in ...)


Suggestions for better wording welcome.


Stu



Index: tk.port.mk
===================================================================
RCS file: /cvs/ports/x11/tk/tk.port.mk,v
diff -u -p -u -p -r1.17 tk.port.mk
--- tk.port.mk	4 Dec 2025 19:07:28 -0000	1.17
+++ tk.port.mk	6 Dec 2025 13:24:22 -0000
@@ -7,6 +7,10 @@ CATEGORIES +=		x11/tk
 MODTK_VERSION ?= 	8.5
 MODTCL_VERSION ?= 	${MODTK_VERSION}
 
+.if "${MODTCL_VERSION}" != "${MODTK_VERSION}"
+ERRORS += "Fatal: versions must be equal: MODTCL_VERSION=${MODTCL_VERSION}, MODTK_VERSION=${MODTK_VERSION}."
+.endif
+
 .if ${MODTK_VERSION} == 8.5
 _MODTK_SPEC = 		tk->=${MODTK_VERSION},<8.6
 MODTK_LIB ?=		tk85