From: Stuart Cassoff Subject: Re: [UPDATE] sysutils/lib{burn,isoburn,isofs} To: Stuart Henderson Cc: Klemens Nanni , OpenBSD Ports Date: Sun, 14 Dec 2025 11:30:10 -0500 Excellent, thanks. So that's what will be committed. On Sun, 14 Dec 2025, Stuart Henderson wrote: > On 2025/12/14 08:29, Stuart Cassoff wrote: > > Just to be sure: "pl1", not ".pl1". > > yes. pkg_add has special handling for certain suffixes including pl > and it doesn't work quite as expected with the extra . > > $ pkg_check-version libisofs-1.5.6.pl01 libisofs-1.5.6 libisofs-1.5.6p1 libisofs-1.5.7 libisofs-1.5.6pl2 > libisofs-*- sorted: libisofs-1.5.6 libisofs-1.5.6p1 libisofs-1.5.6pl2 libisofs-1.5.6.pl01 libisofs-1.5.7 > > > > > > COMMENT = library to create and edit an ISO-9660 filesystem > > > > DISTNAME = libisofs-1.5.6.pl01 > > PKGNAME = libisofs-1.5.6pl1 > > WRKDIST = ${WRKDIR}/libisofs-1.5.6 > > > > SHARED_LIBS = isofs 0.2 # 98.0 > > > > CATEGORIES = sysutils > > HOMEPAGE = https://dev.lovelyhq.com/libburnia/web/wikis/Libisofs > > SITES = http://files.libburnia-project.org/releases/ > > > > # GPLv2+ > > PERMIT_PACKAGE = Yes > > > > WANTLIB = iconv pthread z > > LIB_DEPENDS = converters/libiconv > > > > SEPARATE_BUILD = Yes > > CONFIGURE_STYLE = gnu > > > > CONFIGURE_ENV = CPPFLAGS="-I${LOCALBASE}/include" \ > > LDFLAGS="-L${LOCALBASE}/lib ${LDFLAGS}" > > > > NO_TEST = Yes > > > > .include > > > > > > On Sun, 14 Dec 2025, Stuart Henderson wrote: > > > > > On 2025/12/13 17:57, Stuart Cassoff wrote: > > > > -DISTNAME = libisofs-1.5.4 > > > > -SHARED_LIBS += isofs 0.1 # 97.0 > > > > +DISTNAME = libisofs-1.5.6.pl01 > > > > +SHARED_LIBS = isofs 0.2 # 98.0 > > > > > > could you normalise the package name format please, i.e. add > > > PKGNAME=libisofs-1.5.6pl1 > > > > > > > CATEGORIES = sysutils > > > > - > > > > HOMEPAGE = https://dev.lovelyhq.com/libburnia/web/wikis/Libisofs > > > > SITES = http://files.libburnia-project.org/releases/ > > > > > > > > # GPLv2+ > > > > PERMIT_PACKAGE = Yes > > > > > > > > -WANTLIB = iconv pthread z > > > > +WANTLIB = iconv pthread z > > > > LIB_DEPENDS = converters/libiconv > > > > + > > > > +SEPARATE_BUILD = Yes > > > > CONFIGURE_STYLE = gnu > > > > + > > > > CONFIGURE_ENV = CPPFLAGS="-I${LOCALBASE}/include" \ > > > > LDFLAGS="-L${LOCALBASE}/lib ${LDFLAGS}" > > > > + > > > > +NO_TEST = Yes > > > > + > > > > +WRKDIST = ${WRKDIR}/libisofs-1.5.6 > > > > > > that would be better moved up with DISTNAME so it's more noticeable > > > when updating > > > > > > > >