From: Stuart Henderson <stu@spacehopper.org>
Subject: Re: [NEW] audio/ebook2cw
To: Enzo Nicosia <me@katolaz.net>
Cc: ports@openbsd.org, "Anthony J. Bentley" <anthony@anjbe.name>
Date: Thu, 18 Dec 2025 22:25:15 +0000

On 2025/12/18 16:29, Enzo Nicosia wrote:
> Hello Anthony, 
> CC: Stuart,
> 
> thanks a lot for the feedback. I have now set:
> 
>   CATEGORIES= 	comms hamradio

ah I see, a bunch of things set this even though there's no directory.

> and
> 
>   NO_TEST=	yes
> 
> Regarding DEBUG_PACKAGES I guess the default:
> 
>   DEBUG_PACKAGES=${BUILD_PACKAGES}
> 
> is sane, as this port generates only one package? Sorry if the question

yes

> is moot, but when is DEBUG_PACKAGES suggested/recommended? Is it
> mandatory for all new ports?  I am preparing two more new ports

it's not mandatory for new ports, personally I wouldn't have included
it here (if there is a problem with this code then it should be pretty
easily reproducible), but it's very useful to have debug packages
around if some code is likely to crash in ways which are hard to
reproduce (so you have a better chance of analysing a core without
having to rebuild and then try to reproduce)

> (ebook2cwgui and qrq) and knowing in advance might help avoiding wasting
> bandwidth in the future.
> 
> New tgz with recommended changes attached. Is it OK now?

please keep to a reasonably consistent style within a file for setting
variables, you have

MAKE_FLAGS =    DESTDIR=${PREFIX}
FAKE_FLAGS =    DESTDIR=${WRKINST}${PREFIX}
NO_TEST=yes
DEBUG_PACKAGES=${BUILD_PACKAGES}

would be better as this or similar

MAKE_FLAGS =    DESTDIR=${PREFIX}
FAKE_FLAGS =    DESTDIR=${WRKINST}${PREFIX}
NO_TEST =	yes
DEBUG_PACKAGES = ${BUILD_PACKAGES}

ok

> Regards
> 
> Enzo
> 
> 
> On Thu, Dec 18, 2025 at 05:44:50AM -0700, Anthony J. Bentley wrote:
> > Stuart Henderson writes:
> > > now with actual attachment ;)
> > 
> > ===>  Regression tests for ebook2cw-0.8.5
> > gmake: *** No rule to make target 'test'.  Stop.
> > 
> > Please set NO_TEST=Yes. I would set DEBUG_PACKAGES in this port as well.
> > ok bentley@
> > 
> > > On 2025/12/10 03:08, Stuart Henderson wrote:
> > > > On 2025/12/09 10:38, Enzo Nicosia wrote:
> > > > > Hello,
> > > > > 
> > > > > ebook2cw is a command line program which converts a plain text ebook to
> > > > > morse code MP3 or OGG files. It works on several platforms, including
> > > > > Windows, Linux, FreeBSD and, finally, also OpenBSD.
> > > > > 
> > > > > It automatically splits and numbers the output files by chapters.
> > > > > 
> > > > > For a detailed description, please refer to the man-page or the project
> > > > > website at https://fkurz.net/ham/ebook2cw.html
> > > > > 
> > > > > ebook2cw is distributed under GPLv2.
> > > > > 
> > > > > 
> > > > > 
> > > > > This is my first port, and I am willing to maintain it as I am using it
> > > > > on a regular basis. I have patched the few remaining strcpy/strcat
> > > > > warnings.  
> > > > > 
> > > > > I know that hamradio is not a top-level ports category, but this would
> > > > > definitely belong also to the same category where ham-radio-related
> > > > > ports like tlf or xlog live.
> > > > > 
> > > > > It has been tested on -current amd64, but it also builds and works fine
> > > > > on 7.8 amd64. tar.gz attached.
> > > > > 
> > > > > Is this OK? Any feedback is more than welcome.
> > > > > 
> > > > > Thanks in advance
> > > > > 
> > > > > Enzo
> > > > > 
> > > > > -- 
> > > > 
> > > > 
> > > > tweaked version attached;
> > > > 
> > > > - add a note to COMMENT for people that don't know CW == Morse code
> > > > - CATEGORIES for amateur radio related ports is normally comms so use
> > > >   that (not sure whether that or audio is best for the port dir)
> > > > - more exact license marker
> > > > - don't list library deps in BUILD_DEPENDS
> > > > - break out deps to one line per dep
> > > > - don't use "CONFIGURE_STYLE=none", it is meaningless
> > > > - pass in DESTDIR via flags to avoid various patches
> > > > - use INSTALL_STRIP rather than hardcoding -s (so that building with
> > > >   "make DEBUG=-g" disables stripping)
> > > > - drop DESCR paragraph about manpages and www (the URL is included
> > > >   directly after in packages, so that should be fairly obvious, and
> > > >   manpages are standard anyway
> 
> --