From: Enzo Nicosia <me@katolaz.net>
Subject: Re: [NEW] audio/ebook2cw
To: ports@openbsd.org, "Anthony J. Bentley" <anthony@anjbe.name>, Stuart Henderson <stu@spacehopper.org>
Date: Thu, 18 Dec 2025 23:51:27 +0000

On Thu, Dec 18, 2025 at 10:25:15PM +0000, Stuart Henderson wrote:
> On 2025/12/18 16:29, Enzo Nicosia wrote:
> > Hello Anthony, 
> > CC: Stuart,
> > 
> > thanks a lot for the feedback. I have now set:
> > 
> >   CATEGORIES= 	comms hamradio
> 
> ah I see, a bunch of things set this even though there's no directory.
> 

Yes, I believe multiple categories are captured well by various online
port search engines (openports.pl, ports.su, www.ports.to, etc) even
though directories like "hamradio" are not in the ports tree. 

I checked and bsd.port.mk only enforces one of the tokens in CATEGORIES
to correspond to the parent directory in PKGPATH. The other tokens might
well not exist in the ports tree, at all. If used sparingly, that could
perhaps be useful for online searches.

[cut]

> 
> please keep to a reasonably consistent style within a file for setting
> variables, you have
> 
> MAKE_FLAGS =    DESTDIR=${PREFIX}
> FAKE_FLAGS =    DESTDIR=${WRKINST}${PREFIX}
> NO_TEST=yes
> DEBUG_PACKAGES=${BUILD_PACKAGES}
> 
> would be better as this or similar
> 
> MAKE_FLAGS =    DESTDIR=${PREFIX}
> FAKE_FLAGS =    DESTDIR=${WRKINST}${PREFIX}
> NO_TEST =	yes
> DEBUG_PACKAGES = ${BUILD_PACKAGES}
> 
> ok
> 

Well-spotted, sorry! That was done in haste, and unnecessarily so. Do I
need to send a new tgz with correct indentation or the previous one is
good to be committed by you/Anthony?

Regards

Enzo

--