From: Edd Barrett <edd@theunixzoo.co.uk>
Subject: Re: Upgrade net/syncthing to v2
To: Douglas Silva <doug.hs@proton.me>
Cc: "ports@openbsd.org" <ports@openbsd.org>, "kn@openbsd.org" <kn@openbsd.org>, Lydia Sobot <chilledfrogs@disroot.org>
Date: Sun, 28 Dec 2025 19:34:03 +0000

Hi,

Thanks for looking into this. The diff looks fine so far.

I've not had a chance to test this yet, but one question I have is: is v2
backward compatible with v1? That can be split into two sub-questions:

 - 1) Does the user have to do anything to migrate an existing v1 instance?
 - 2) Does v2 speak to existing v1 nodes OK?

1) is answered in the release notes:

```
Database backend switched from LevelDB to SQLite. There is a migration on first
launch which can be lengthy for larger setups. The new database is easier to
understand and maintain and, hopefully, less buggy.
```

2), I'm not sure about. Have you been able to sync between v2 and v1? If they
are not compatible, we will have to devise an upgrade strategy.

One more thing:

>  +	if err := unix.Unveil("/usr/local/bin/syncthing", "rx"); err != nil {
>  +		panic(err)
>  +	}
> ++
>  +	if err := unix.Unveil("/usr/local/bin/xdg-open", "rx"); err != nil {
>  +		panic(err)
>  +	}

^ There are some (pre-existing) hard-coded paths in this patch. We should fix
these as a separate commit.

Cheers

-- 
Best Regards
Edd Barrett

https://www.theunixzoo.co.uk