From: Sebastien Marie <semarie@kapouay.eu.org>
Subject: lang/go: use MODGO_TEST_CMD for MODGO_TEST_TARGET
To: ports@openbsd.org
Date: Sat, 03 Jan 2026 08:20:50 +0100

Hi,

The default do-test target for lang/go modules is defined as:

    MODGO_TEST_TARGET ?=    cd ${WRKSRC} && ${MODGO_CMD} ${ALL_TARGET}

but it also exists MODGO_TEST_CMD which takes care of ${MODGO_FLAGS} and
${MODGO_TEST_FLAGS}.

The main difference is ${MODGO_FLAGS} and ${MODGO_TEST_FLAGS} usage with
MODGO_TEST_CMD (and nothing else).

I tested several ports (but not all), and it seems fine.

The usage of ALL_TARGET as (not overridable) default target for testing
is also questionnable, but I would like to address it in separated
discussion (lot of go modules are overriding do-test for defining custom
target).

Comments or OK ?
-- 
Sebastien Marie


diff --git a/lang/go/go.port.mk b/lang/go/go.port.mk
index 8b58b6b048..48427c2576 100644
--- a/lang/go/go.port.mk
+++ b/lang/go/go.port.mk
@@ -110,7 +110,7 @@
 .  endif
 .endif
 
-MODGO_TEST_TARGET ?=	cd ${WRKSRC} && ${MODGO_CMD} test ${ALL_TARGET}
+MODGO_TEST_TARGET ?=	cd ${WRKSRC} && ${MODGO_TEST_CMD} ${ALL_TARGET}
 
 SEPARATE_BUILD ?=	Yes