From: Matthias Kilian <kili@outback.escape.de>
Subject: Re: devel/cabal: add port update tools
To: Greg Steuck <gnezdo@openbsd.org>
Cc: Klemens Nanni <kn@openbsd.org>, ports@openbsd.org
Date: Thu, 15 Jan 2026 22:45:50 +0100

Hi,

I didn't have the time to play with this[1], but...

On Sun, Jan 11, 2026 at 03:34:07PM -0800, Greg Steuck wrote:
> >> The batch script finds all ports using devel/cabal module and can
> >> update
> >> them in sequence, with optional git commits per port.
> >
> > So /usr/ports must be git, not CVS?
> 
> I don't use CVS outside of commits to cvs.o.o so I'm not the best person
> to add such a mode.

Would it be an option do drop the automatic commit feature (-g) for
now and instead just print what should be committed, and let the
update-cabal-port script indicate wether nothing has been changed
by a special exit code, like 2 (which isn't used yet)? This would
allow to not call git at all. (And for sure you won't want automatic
commits to CVS ;-))

> >> +UPDATE_SCRIPT="./devel/cabal/tools/update-cabal-port.pl"
> >> +[[ -x "$UPDATE_SCRIPT" ]] || { print -u2 "Update script not found:
> >> $UPDATE_SCRIPT"; exit 1; }
> >
> > Reads like it must be run from PORTSDIR, in which case an up-front test
> > that you're really in /usr/ports/ seems appropiate.
> 
> I'm not sure what that check would look like. The obvious `cd
> /usr/ports` doesn't feel right.

You could do something like

	: ${PORTSDIR:=/usr/ports}
	...
	cd ${PORTSDIR} || exit 1

Ciao,
	Kili

[1] I'm aware that I'm unavailable at a terrible level, but if you
have too deal with electronic invoicing with special rules made in
germany[tm], you often feel like quitting any activity around
software is the only way to stay sane ;-)