From: "Anthony J. Bentley" Subject: Re: NEW: games/fallout1-ce -> 1.1.0 && games/fallout2-ce -> 1.3.0 To: izzy Meyer Cc: ports@openbsd.org, Thomas Frohwein , "Kirill A. Korinsky" Date: Sat, 07 Feb 2026 22:49:13 -0700 izzy Meyer writes: > On Sat, 10 Jan 2026 21:56:18 -0600 > izzy Meyer wrote: > > > On Sat, 10 Jan 2026 15:39:33 -0800 > > Thomas Frohwein wrote: > > > > > On Fri, 09 Jan 2026 20:28:40 +0100 > > > Kirill A. Korinsky wrote: > > > > > > > On Thu, 08 Jan 2026 23:18:57 +0100, > > > > Thomas Frohwein wrote: > > > > > > > > > > PS: there is a precedent: games/devilutionx also has Sustainable > > > > > Use License 1.0 and is PERMIT_PACKAGE=Yes > > > > > > > > I see, when it seems that I had too pesimistic view for the world. > > > > > > > > > > I reviewed the port fallout1-ce. It works here, but only with the > > > included CFLAGS=-O1 -pipe, which bugs me that it's not clear why -O2 > > > crashes. I'm attaching the backtrace from the corefile, in case > > > anyone can make sense why only O2+ crashes here. > > > > > > In general, it's probably easier to figure out the open questions > > > for one of the ports first, rather than discussing both together. > > > Once we got it sorted out, knowing how to deal with the other port > > > will probably be more straightforward, given the similarities. > > > > > > Regarding the other issues that have been raised: > > > > > > 1) I'm in favor of CATEGORIES=games x11, as it puts the most > > > relevant category first. > > > > > > 2) I don't have an opinion on fpattern as a port. For sake of moving > > > things along, I'd suggest that we consider importing fallout1-ce > > > with the bundled fpattern first. We can later see after a possible > > > fpattern port about using that rather than the bundled one. > > > > > > 3) README is clear enough for me as is. > > > > > > 4) We should be able to do just PERMIT_PKG=Yes like > > > games/devilutionx which has the same license. > > > > > > From my side ok thfr@ to import fallout1-ce, with the change to > > > CATEGORIES in 1). > > > > Attached is a cleaned up fallout1-ce port with the above suggestions, > > as well as me added as a maintainer as I forgot to add myself > > there earlier. > > > > > > Ping! I have a rule of thumb: if a port has ever crashed for anyone for any reason, even if that reason has been fixed or worked around, I set DEBUG_PACKAGES. thfr@ reported a crash with -O2, so this one qualifies. (I would probably set DEBUG_PACKAGES for any graphics-heavy port anyway. A crash in such a port is likely to be GPU-dependent, so we want full backtraces to be easy to get since it might be hard for another person to reproduce.) However, DEBUG_PACKAGES doesn't work out of the box on this port since you override CFLAGS thus overriding -g, you need to change the lines to: # -O2+ causes instability and segfaults CFLAGS = -O1 -pipe ${DEBUG} CXXFLAGS = -O1 -pipe ${DEBUG} Testing was sorta successful. Fallout 1 is in my GOG library twice for some reason. One title provides setup_fallout_1.2_(27130).exe and setup_fallout_1.2_(27130)-1.bin as downloads, and the other provides setup_fallout_2.1.0.18.exe. I ran innoextract against both. This port seems to work with 2.1.0.18 but not with 1.2_(27130). With 1.2_(27130) I got a fullscreen "Please stand by", but then got kicked back to the desktop, with the process still running (not crashed). Weird. I think it's worth mentioning in the README that not all versions work even when downloaded straight from GOG.