From: Stuart Henderson <stu@spacehopper.org>
Subject: Re: NEW DEPENDENCY: sysutils/afflib3
To: Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>
Cc: ports <ports@openbsd.org>
Date: Wed, 18 Feb 2026 14:20:03 +0000

On 2026/02/17 09:31, Sebastian Reitenbach wrote:
> Hi,
> 
> pinging, for convenience, tarball attached again.
> This is a new dependency for updating sleuthkit.

$ make show=PKGNAMES
afflibv3-3.7.22

this should ideally match the port directory name, i.e. get rid of the
extra 'v', for example

PKGNAME =	afflib3-${VERSION}

no need to set USE_LIBTOOL=Yes (that is the default anyway)

with those (and optionally the one below), ok 

: CONFIGURE_ENV +=        CXXFLAGS="${CXXFLAGS} -Disnumber=isdigit" \

I wondered about this, I think it might be better to patch
tools/affcopy.cpp instead, then it's a bit more self-documenting?

-#if (!defined(__BSD_VISIBLE) || defined(__CYGWIN__)) && !defined(isnumber)
+#if !defined(isnumber)
 #define isnumber(x) isdigit(x)
 #endif


> any comments, feedback etc. welcome.
> 
> cheers,
> Sebastian
> 
> On Wed, Feb 11, 2026 at 8:29 PM Sebastian Reitenbach <sebastia@l00-bugdead-prods.de> wrote:
> 
>     and here's the missing tarball attached this time.
> 
>     this is a new dependency for sysutils/sleuthkit.
> 
>     cat pkg/DESCR
>     AFFLibv3 (Advanced Forensic Format Library version 3) is an open-source
>     library and toolkit used to create, manage, and analyze disk images in
>     the Advanced Forensic Format (AFF).
> 
>     Due to the number of tools it brings, I placed it under sysutils.
> 
>     Tests all succeed.
> 
>     Any comments, etc. or even OKs to import welcome.
> 
>     cheers,
>     Sebastian
> 
> 
>     On Wed, Feb 11, 2026 at 2:38 PM Sebastian Reitenbach <sebastia@l00-bugdead-prods.de> wrote:
> 
>         Hi,
> 
>         this is a new dependency for sysutils/sleuthkit.
> 
>         cat pkg/DESCR
>         AFFLibv3 (Advanced Forensic Format Library version 3) is an open-source
>         library and toolkit used to create, manage, and analyze disk images in
>         the Advanced Forensic Format (AFF).
> 
>         Due to the number of tools it brings, I placed it under sysutils.
> 
>         Tests all succeed.
> 
>         Any comments, etc. or even OKs to import welcome.
> 
>         cheers,
>         Sebastian
>