From: Antoine Jacoutot <ajacoutot@bsdfrog.org>
Subject: Re: hplip: fix a dumb implicit-int error
To: ports@openbsd.org
Date: Fri, 27 Mar 2026 08:43:33 +0100

On Thu, Mar 26, 2026 at 08:25:28PM +0100, Claudio Jeker wrote:
> On Wed, Mar 25, 2026 at 11:32:40AM +0100, Antoine Jacoutot wrote:
> > On Wed, Mar 25, 2026 at 11:01:17AM +0100, Claudio Jeker wrote:
> > > ports-gcc does error out on implicit-int errors. hplip has one of those
> > > and the fix is trivial.
> > > 
> > > On top of this it seems that -hpcups does not need ${COMPILER_LIBCXX} at
> > > least this cause some strange issues on my sparc64 build box. Now that
> > > part I'm not sure about so someone understanding this should double check.
> > 
> > Should be OK. ok for me with appropriate bumps.
> 
> Like below? Is that enough bumps?
> IMO the -Wimplicit-int fix does not need a bump but the WANTLIB change
> needs one, correct?

Correct :-)
OK for me.

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/print/hplip/Makefile,v
> diff -u -p -r1.226 Makefile
> --- Makefile	18 Nov 2025 10:04:39 -0000	1.226
> +++ Makefile	25 Mar 2026 15:54:51 -0000
> @@ -18,6 +18,8 @@ PKGNAME-hpcups=		hpcups-${V}
>  PKGNAME-hpijs=		hpijs-${V}
>  PKGNAME-gui=		hplip-gui-${V}
>  
> +REVISION-hpcups=	0
> +
>  SHARED_LIBS +=  hpdiscovery          0.0      # 0.1
>  SHARED_LIBS +=  hpmud                2.0      # 0.6
>  SHARED_LIBS +=  hpipp                0.0      # 0.1
> @@ -99,7 +101,7 @@ RUN_DEPENDS-hpaio=	# empty
>  
>  ### -hpcups
>  WANTLIB-hpcups += ${cWANTLIB} z netsnmp hpdiscovery iconv intl ssl
> -WANTLIB-hpcups += c jpeg ${COMPILER_LIBCXX} hpip cups cupsimage dbus-1
> +WANTLIB-hpcups += c jpeg hpip cups cupsimage dbus-1
>  WANTLIB-hpcups += z usb-1.0 avahi-client avahi-common hpmud avahi-core
>  
>  LIB_DEPENDS-hpcups=	graphics/jpeg \
> Index: patches/patch-prnt_hpps_pserror_c
> ===================================================================
> RCS file: patches/patch-prnt_hpps_pserror_c
> diff -N patches/patch-prnt_hpps_pserror_c
> --- /dev/null	1 Jan 1970 00:00:00 -0000
> +++ patches/patch-prnt_hpps_pserror_c	15 Dec 2025 12:53:37 -0000
> @@ -0,0 +1,14 @@
> +Fix for -Wimplicit-int
> +
> +Index: prnt/hpps/pserror.c
> +--- prnt/hpps/pserror.c.orig
> ++++ prnt/hpps/pserror.c
> +@@ -24,7 +24,7 @@ extern char *program ;	/* Defined by main program, giv
> + void message(int flags, char *format, ...)
> + {
> +   va_list args ;
> +-  static column = 0 ;		/* current screen column for message wrap */
> ++  static int column = 0 ;	/* current screen column for message wrap */
> +   char msgbuf[MAX_MESSAGE] ;	/* buffer in which to put the message */
> +   char *bufptr = msgbuf ;	/* message buffer pointer */
> + 
> 

-- 
Antoine