From: Kirill A. Korinsky <kirill@korins.ky>
Subject: Re: new ports: fonts/adobe-fonts/source-han-*
To: ports@openbsd.org
Date: Sun, 29 Mar 2026 12:13:23 +0200

On Sun, 29 Mar 2026 07:04:49 +0200,
"Anthony J. Bentley" <bentley@openbsd.org> wrote:
> 
> Kirill A. Korinsky writes:
> > I'd like to import adobe-fonts/source-han fonts family.
> 
> Very nice. Some comments:
> 
> - The ports rename the distfiles to add version numbers, but also drop
>   other components of the filenames, so it's no longer obvious what
>   upstream distfile they correspond to. I would preserve the upstream
>   naming scheme, replacing this:
> 
>     SourceHanSans-${ADOBE_TAGNAME}{02_SourceHanSans-VF}.zip
> 
>   with this:
> 
>     02_SourceHanSans-VF-${ADOBE_TAGNAME}{02_SourceHanSans-VF}.zip
> 
>   But we can avoid renaming entirely by setting a versioned DIST_SUBDIR.
>   That's usually clearer IMO, and it's particularly helpful in these
>   ports since upstream provides 20+ distfiles each and choosing the
>   right ones is extremely confusing.
> 
> - The ports only install the full-width fonts, but half-width should be
>   installed as well.
> 
> - The ports only install variable fonts. A while back I dropped static
>   fonts from noto-cjk in favor of variable fonts, but I'm starting to
>   feel that was a mistake: variable fonts render differently and have a
>   different family name in fc-list, so I think we should install both.
>   Luckily, if we switch the variable fonts to TTC the resulting package
>   is smaller, even adding the static TTC, than a package with variable
>   TTF/OTF and no static fonts.
> 
> - The web packages should install the subsetted fonts too. The package
>   gets bigger but provides individual files that are smaller, useful
>   in a web context.
> 
> Here's a diff against the version you sent, with which it's ok bentley@:
> 

Thanks for idea with DIST_SUBDIR, it makes port cleaner, special mono.

Here an updated .tgz which incorporated all your changes plus new mono port.

-- 
wbr, Kirill