From: Landry Breuil <landry@openbsd.org>
Subject: Re: UPDATE: net/slurm
To: ports@openbsd.org
Date: Tue, 21 Apr 2026 19:06:32 +0200

Le Mon, Apr 20, 2026 at 05:31:46PM -0700, Ryan Freeman a écrit :
> Hi,
> 
> Attached is a patch to pull net/slurm up to version 0.4.4 with additional
> patches from an open PR: https://github.com/mattthias/slurm/pull/53
> 
> 0.4.3 to 0.4.4 does change the build system to meson.
> Installing the manpage is no-longer a manual step in the port Makefile.
> OpenBSD ports patches were pulled in upstream, except the manpage patch.
> This one is pulled upstream but after the 0.4.4 release, so the local
> patch remains: https://github.com/mattthias/slurm/commit/ef79c98269eb16bc49efcb520588a379c99f4f57
> 
> The PR adds several fixes, important enough to bring them in (almost)
> entirely.  Changes for code paths limited to other platforms are ignored.
> 
> The PR has been open for 2 years, but I did post indicating the fixes worked
> good for me, hopefully @mattthias merges the request.
> 
> applied from Iksas' pull request:
> - fix out-of-bounds accesses of _x_speedarray 4873377
> - remove unused constants 7a47a63
> - tidy up height constants cc6d46d
> - fix an error where ERR_IFACE_DOWN would never be set 0111751
> - wrap numerical constants in parantheses to prevent silent errors in the future 8b673e9
> - fix calculation of maximum speed 32e054a
> - fix a bug where the graph would not automatically re-scale c8c32a9
> - make sure graphs are centered when a terminal of width 80 is used c2022b3
> - fix more out-of-bounds memory accesses 362f597
> - fix graph rescaling in classic mode (-c) 323d2bf
> 
> ignored parts of the pull request:
> - patch for src/hpux.c
> - patch for os.h, dealing with constants when building for HP-UX or Solaris
> 
> Is this an OK direction for pulling in these outside patches?  Is using 'pl'
> the appropriate marker under PKGNAME?

i'd make my life simpler by simply pointing at

DIST_TUPLE =	github Iksas slurm ${sha_of_latest_commit} .
with a comment saying why we pick this upstream repo. this way, less
patches :)

briefly tested and works fine, i had totally forgot about slurm, used it
ages ago...