From: Daniil Ryvkin <mail@leinadr.com>
Subject: Re: [new port] devel/zls
To: Volker Schlecht <openbsd-ports@schlecht.dev>
Cc: ports@openbsd.org
Date: Tue, 7 Jul 2026 23:05:05 +0300

On Tue, 7 Jul 2026 21:01:24 +0200
Volker Schlecht <openbsd-ports@schlecht.dev> wrote:

> On 7/5/26 1:52 AM, Daniil Ryvkin wrote:
> > ZLS 0.16.0, a language server for the Zig programming language.
> > Tested on openbsd-current amd64.  
> 
> Looks largely really good to me.
> I would suggest
> 
> * Add -Dcpu so that the resulting binary runs on more than the CPU of
> the ports builder :-)
> * Add "--verbose" and "--color off" to make the build log more
> palatable
> * Add -j${MAKE_JOBS}
> * I believe ONLY_FOR_ARCHS isn't needed, because those are the zig
> archs and if it should be needed, it should go to the top of the
> Makefile
> 
> I built and tested your port with the attached diff, and from what I
> can tell, it does what it's supposed to do - with those changes, ok
> volker@

Thanks for the review, no issues on my end!