From: Stuart Henderson <stu@spacehopper.org>
Subject: Re: UPDATE: libiscsi 1.20.3
To: <yaydn@protonmail.com>, Brad Smith <brad@comstyle.com>, <ports@openbsd.org>
Date: Mon, 10 Aug 2026 01:31:36 +0100

we don't really need the pasted output from applying the patch, running 
tests, etc - it's quite a lot of noise in your messages which makes it 
harder to spot any times when you found a problem.

-- 
  Sent from a phone, apologies for poor formatting.

On 9 August 2026 19:27:22 yaydn@protonmail.com wrote:

> På søndag 9. august 2026 kl. 07:59, skrev Brad Smith
> <brad@comstyle.com>:
>
>> On Sat, Aug 08, 2026 at 11:45:38PM -0400, Brad Smith wrote:
>>> Here is an update to libiscsi 1.20.3.
>>>
>>>
>>> fix several vulnerabilities parsing data-in
>>>
>>> libiscsi: memory-safety issues decoding malformed SCSI target responses
>>>
>>> 1.20.3
>>> - When queueing the first PDU to an idle socket, immediately try to write
>>> it to the socket instead of waiting for the event-loop to
>>> timeout/notice there is work to do.
>>> - Various other small bugfixes.
>>>
>>> 1.20.1
>>> - Add sha1/sha256/sha3 authentication
>>> - Add multithreading support
>>
>> Fix remotely triggerable memory-safety bugs and add a CMake build
>
>
> $ cd /usr/ports/devel/libiscsi/ && patch -l -p0 -E < /tmp/libiscsi-1.20.3.diff
>
> $ cd /usr/ports/devel/libiscsi/ && make build package test ; make 
> port-lib-depends-check check-shlib-syms clean
>
> No regression tests for libiscsi-1.20.3pl20260809
> /usr/local/lib/libiscsi.so.2.1 --> 
> /usr/ports/pobj/libiscsi-1.20.3pl20260809/fake-amd64/usr/local/lib/libiscsi.so.2.2
> Dynamic export changes:
> added:
> iscsi_mt_service_thread_start
> iscsi_mt_service_thread_stop
> scsi_alua_state_to_str
> scsi_cdb_report_target_port_groups
>
> ===>  Cleaning for libiscsi-1.20.3pl20260809
> --
>
> # TRUSTED_PKG_PATH=/usr/ports/packages/amd64/all/ pkg_add -Dsnap -u libiscsi
> libiscsi-1.20.0p0->1.20.3pl20260809: ok
> --
>
> Builds on current/amd64 with privsep.
>
> Hope these all help.
> --
> yaydn
>
>>
>> Index: Makefile
>> ===================================================================
>> RCS file: /cvs/ports/devel/libiscsi/Makefile,v
>> retrieving revision 1.10
>> diff -u -p -u -p -r1.10 Makefile
>> --- Makefile 24 Nov 2025 13:24:08 -0000 1.10
>> +++ Makefile 9 Aug 2026 05:37:58 -0000
>> @@ -1,13 +1,12 @@
>> COMMENT= client-side library to implement the iSCSI protocol
>>
>> -DISTNAME= libiscsi-1.20.0
>> -REVISION= 0
>> +DISTNAME= libiscsi-1.20.3pl20260809
>> GH_ACCOUNT= sahlberg
>> GH_PROJECT= libiscsi
>> -GH_COMMIT= b8d9fbf5e3120dde1a95ca7d873117f4e911b86c
>> +GH_COMMIT= 1985697419d25a62a04e7454ca8185b854b66ad3
>> CATEGORIES= devel net
>>
>> -SHARED_LIBS= iscsi 2.1
>> +SHARED_LIBS= iscsi 2.2
>>
>> HOMEPAGE= https://github.com/sahlberg/libiscsi
>>
>> @@ -20,16 +19,14 @@ PERMIT_PACKAGE= Yes
>> COMPILER= base-clang ports-gcc
>> COMPILER_LANGS= c
>>
>> -WANTLIB= c
>> +WANTLIB= c pthread
>>
>> -AUTOCONF_VERSION= 2.71
>> -AUTOMAKE_VERSION= 1.16
>> +MODULES+= devel/cmake
>>
>> -USE_GMAKE= Yes
>> -CONFIGURE_STYLE= autoreconf
>> +CONFIGURE_ARGS+= -DENABLE_WERROR=Off \
>> + -DWITH_GNUTLS=No \
>> + -DWITH_LIBGCRYPT=No
>>
>> -CONFIGURE_ARGS+= --disable-werror \
>> - --without-gnutls \
>> - --without-libgcrypt
>> +NO_TEST= Yes
>>
>> .include <bsd.port.mk>
>> Index: distinfo
>> ===================================================================
>> RCS file: /cvs/ports/devel/libiscsi/distinfo,v
>> retrieving revision 1.4
>> diff -u -p -u -p -r1.4 distinfo
>> --- distinfo 20 Jul 2025 14:53:29 -0000 1.4
>> +++ distinfo 9 Aug 2026 05:37:58 -0000
>> @@ -1,2 +1,2 @@
>> -SHA256 (libiscsi-1.20.0-b8d9fbf5.tar.gz) = 
>> CyCRVGVp24e3lu8jmmJqHeJOF5eTEQ3quDjGykK1pt4=
>> -SIZE (libiscsi-1.20.0-b8d9fbf5.tar.gz) = 316069
>> +SHA256 (libiscsi-1.20.3pl20260809-19856974.tar.gz) = 
>> JYQbhHNp4518OCLPV2yauah35hz0DIt8fWqFqHtwqKY=
>> +SIZE (libiscsi-1.20.3pl20260809-19856974.tar.gz) = 345435
>> Index: pkg/PLIST
>> ===================================================================
>> RCS file: /cvs/ports/devel/libiscsi/pkg/PLIST,v
>> retrieving revision 1.5
>> diff -u -p -u -p -r1.5 PLIST
>> --- pkg/PLIST 20 Jul 2025 14:53:29 -0000 1.5
>> +++ pkg/PLIST 9 Aug 2026 05:37:58 -0000
>> @@ -6,12 +6,17 @@
>> @bin bin/iscsi-perf
>> @bin bin/iscsi-pr
>> @bin bin/iscsi-readcapacity16
>> +@bin bin/iscsi-rtpg
>> @bin bin/iscsi-swp
>> include/iscsi/
>> include/iscsi/iscsi.h
>> include/iscsi/scsi-lowlevel.h
>> -@static-lib lib/libiscsi.a
>> -lib/libiscsi.la
>> +lib/cmake/
>> +lib/cmake/libiscsi/
>> +lib/cmake/libiscsi/libiscsi-config-version.cmake
>> +lib/cmake/libiscsi/libiscsi-config.cmake
>> +lib/cmake/libiscsi/libiscsi-targets${MODCMAKE_BUILD_SUFFIX}
>> +lib/cmake/libiscsi/libiscsi-targets.cmake
>> @lib lib/libiscsi.so.${LIBiscsi_VERSION}
>> lib/pkgconfig/libiscsi.pc
>> @man man/man1/iscsi-inq.1