From: Theo Buehler <tb@theobuehler.org>
Subject: devel/jujutsu: fish completions
To: ports@openbsd.org, semarie@openbsd.org
Date: Mon, 31 Aug 2026 10:21:28 +0200

I got a report that fish completions don't work properly for jj. That
is, command completions work, but revision and bookmark completions
(which seem just as useful to have completions for) do not. Turns out
the packaged completions get in the way of this.

jj has supported (experimental) dynamic completions for fish out of the
box for a long time (around 0.24). This only works with fish >=4.0.2.
So the downside of doing this is that fish 3 users need to install
completions manually by doing 'jj util completion fish | source'

It seems a reasonable trade-off to me, but I'm not a user of these
facilities.

Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/jujutsu/Makefile,v
diff -u -p -r1.38 Makefile
--- Makefile	12 Aug 2026 10:49:05 -0000	1.38
+++ Makefile	31 Aug 2026 08:11:51 -0000
@@ -2,7 +2,7 @@ COMMENT =		version control system with g
 
 V =			0.44.0
 PKGNAME =		jujutsu-$V
-REVISION =		0
+REVISION =		1
 
 DIST_TUPLE =		github jj-vcs jj v$V .
 
@@ -42,7 +42,6 @@ JJ =	${WRKBUILD}/target/release/jj
 post-build:
 	cd /tmp && ${JJ} util install-man-pages ${WRKBUILD}
 	cd /tmp && ${JJ} util completion bash > ${WRKBUILD}/jj.bash
-	cd /tmp && ${JJ} util completion fish > ${WRKBUILD}/jj.fish
 	cd /tmp && ${JJ} util completion zsh > ${WRKBUILD}/jj.zsh
 
 post-install:
@@ -50,12 +49,9 @@ post-install:
 	${INSTALL_MAN} ${WRKBUILD}/man1/* ${PREFIX}/man/man1
 	${INSTALL_DATA_DIR} \
 		${PREFIX}/share/bash-completion/completions \
-		${PREFIX}/share/fish/vendor_completions.d \
 		${PREFIX}/share/zsh/site-functions
 	${INSTALL_DATA} ${WRKBUILD}/jj.bash \
 		${PREFIX}/share/bash-completion/completions/jj
-	${INSTALL_DATA} ${WRKBUILD}/jj.fish \
-		${PREFIX}/share/fish/vendor_completions.d/jj.fish
 	${INSTALL_DATA} ${WRKBUILD}/jj.zsh \
 		${PREFIX}/share/zsh/site-functions/_jj
 
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/devel/jujutsu/pkg/PLIST,v
diff -u -p -r1.16 PLIST
--- pkg/PLIST	6 Aug 2026 08:49:36 -0000	1.16
+++ pkg/PLIST	31 Aug 2026 08:11:31 -0000
@@ -121,5 +121,4 @@
 @man man/man1/jj-workspace.1
 @man man/man1/jj.1
 share/bash-completion/completions/jj
-share/fish/vendor_completions.d/jj.fish
 share/zsh/site-functions/_jj