From: "Anthony J. Bentley" Subject: Re: [new] audio/drc To: ports@openbsd.org Date: Tue, 08 Sep 2026 04:14:58 -0600 Laurence Tratt writes: > On Mon, Aug 31, 2026 at 06:57:31PM +0200, Ingo Schwarze wrote: > > Documentation having a size of 35 MB is certainly not good, and on first > > sight, this particular documentation doesn't appear to be well-organized, > > but it does look like it contains a lot of information, so if you are > > willing to search your way through it, it is probably worth having. > > Again, poor and messy documentation is better than none at all. > > Point taken! Update attached. I gave this a try, but it fails to build on -current: _fft.o gsl/error.o gsl/stream.o minIni/minIni.o -lm spline.cpp:864:16: error: call to 'abs' is ambiguous 864 | ...if (std::abs(ML) > std::abs(DMAX)) | ^~~~~~~~~~~~~~~~ /usr/include/c++/v1/__math/abs.h:52:52: note: candidate function [with $0 = double] 52 | [[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI inline int abs(int __x) ... | ^ /usr/include/c++/v1/__math/abs.h:57:53: note: candidate function [with $0 = double] 57 | [[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI inline long abs(long __x... | ^ /usr/include/c++/v1/__math/abs.h:62:58: note: candidate function [with $0 = double] 62 | [[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI inline long long abs(lon... | ^ spline.cpp:864:39: error: call to 'abs' is ambiguous 864 | ...if (std::abs(ML) > std::abs(DMAX)) | ^~~~~~~~~~~~~~~~ /usr/include/c++/v1/__math/abs.h:52:52: note: candidate function [with $0 = double] 52 | [[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI inline int abs(int __x) ... | ^ /usr/include/c++/v1/__math/abs.h:57:53: note: candidate function [with $0 = double] 57 | [[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI inline long abs(long __x... | ^ /usr/include/c++/v1/__math/abs.h:62:58: note: candidate function [with $0 = double] 62 | [[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI inline long long abs(lon... | ^ spline.cpp:876:16: error: call to 'abs' is ambiguous 876 | ...C1 = std::abs(DP); | ^~~~~~~~~~~~~~~~ /usr/include/c++/v1/__math/abs.h:52:52: note: candidate function [with $0 = double] 52 | [[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI inline int abs(int __x) ... | ^ /usr/include/c++/v1/__math/abs.h:57:53: note: candidate function [with $0 = double] 57 | [[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI inline long abs(long __x... | ^ /usr/include/c++/v1/__math/abs.h:62:58: note: candidate function [with $0 = double] 62 | [[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI inline long long abs(lon... | ^ spline.cpp:877:16: error: call to 'abs' is ambiguous 877 | ...C2 = std::abs(DK); | ^~~~~~~~~~~~~~~~ /usr/include/c++/v1/__math/abs.h:52:52: note: candidate function [with $0 = double] 52 | [[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI inline int abs(int __x) ... | ^ /usr/include/c++/v1/__math/abs.h:57:53: note: candidate function [with $0 = double] 57 | [[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI inline long abs(long __x... | ^ /usr/include/c++/v1/__math/abs.h:62:58: note: candidate function [with $0 = double] 62 | [[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI inline long long abs(lon... | ^ spline.cpp:916:16: error: call to 'abs' is ambiguous 916 | ...if (std::abs(MU) > std::abs(DMAX)) | ^~~~~~~~~~~~~~~~ /usr/include/c++/v1/__math/abs.h:52:52: note: candidate function [with $0 = double] 52 | [[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI inline int abs(int __x) ... | ^ /usr/include/c++/v1/__math/abs.h:57:53: note: candidate function [with $0 = double] 57 | [[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI inline long abs(long __x... | ^ /usr/include/c++/v1/__math/abs.h:62:58: note: candidate function [with $0 = double] 62 | [[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI inline long long abs(lon... | ^ spline.cpp:916:39: error: call to 'abs' is ambiguous 916 | ...if (std::abs(MU) > std::abs(DMAX)) | ^~~~~~~~~~~~~~~~ /usr/include/c++/v1/__math/abs.h:52:52: note: candidate function [with $0 = double] 52 | [[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI inline int abs(int __x) ... | ^ /usr/include/c++/v1/__math/abs.h:57:53: note: candidate function [with $0 = double] 57 | [[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI inline long abs(long __x... | ^ /usr/include/c++/v1/__math/abs.h:62:58: note: candidate function [with $0 = double] 62 | [[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI inline long long abs(lon... | ^ spline.cpp:928:16: error: call to 'abs' is ambiguous 928 | ...C1 = std::abs(DK); | ^~~~~~~~~~~~~~~~ /usr/include/c++/v1/__math/abs.h:52:52: note: candidate function [with $0 = double] 52 | [[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI inline int abs(int __x) ... | ^ /usr/include/c++/v1/__math/abs.h:57:53: note: candidate function [with $0 = double] 57 | [[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI inline long abs(long __x... | ^ /usr/include/c++/v1/__math/abs.h:62:58: note: candidate function [with $0 = double] 62 | [[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI inline long long abs(lon... | ^ spline.cpp:929:16: error: call to 'abs' is ambiguous 929 | ...C2 = std::abs(DN); | ^~~~~~~~~~~~~~~~ /usr/include/c++/v1/__math/abs.h:52:52: note: candidate function [with $0 = double] 52 | [[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI inline int abs(int __x) ... | ^ /usr/include/c++/v1/__math/abs.h:57:53: note: candidate function [with $0 = double] 57 | [[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI inline long abs(long __x... | ^ /usr/include/c++/v1/__math/abs.h:62:58: note: candidate function [with $0 = double] 62 | [[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI inline long long abs(lon... | ^ 8 errors generated. Once that's fixed I don't have any complaints about the port, except I would set DEBUG_PACKAGES=${BUILD_PACKAGES}, and I would replace the first hunk of the makefile patch with: MAKE_FLAGS = CC="${CC}" \ CXX="${CXX}" \ CFLAGS="${CFLAGS}" \ CXXFLAGS="${CXXFLAGS}" \ CPPFLAGS=-I. But honestly both of those are optional.