From: Kurt Miller <lists@intricatesoftware.com>
Subject: Re: NEW: java/sevenzipjbinding
To: Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>
Cc: ports@openbsd.org, kurt@openbsd.org
Date: Sat, 3 Oct 2026 00:02:37 +0000

On Oct 2, 2026, at 3:27 PM, Sebastian Reitenbach <sebastia@l00-bugdead-prods.de> wrote:
> 
> This is the cleaned-up, updated version, installing the .jars in $MODJAVA_JAR_DIR
> It's needed dependency for Autopsy.
> 
> obviously, for after unlock.
> 
> any testing, feedback etc. welcome.
> 

I took a brief look at the Makefile and have some suggestions. I
did not build or test this yet.

Yes this should go under archivers. We try to avoid putting ports
in the java category as the primary category. 

-CATEGORIES =	archivers java
+CATEGORIES =	archivers

java.port.mk will add the secondary java category for you.

-MODJAVA_VER =	21
+MODJAVA_VER =	11+

According to the build instructions this port is Java JDK 1.5
or higher. We set the lowest possible jdk for MODJAVA_VER and
generally use ‘+' to allow higher versions to use it as well. Right
now our lowest jdk is 11 and ‘+' make sense unless a higher jdk
can’t use the jars.

	# Install native JNI shared object
	${INSTALL_DATA_DIR} ${PREFIX}/lib/sevenzipjbinding
	${INSTALL_DATA} ${WRKBUILD}/jbinding-cpp/lib7-Zip-JBinding.so \
		${PREFIX}/lib/sevenzipjbinding/

Is this really needed? Usually jni shared objects are stored within the
jar and java can utilize it just fine there. Please show what fails
if you do not install this in the lib subdirectory.

Also something is not right with ARCH and your PLIST:

share/java/classes/sevenzipjbinding-OpenBSD-amd64.jar

That amd64 should not be in your PLIST. I thought make update-plist
would substitute that for you back to ${ARCH}.

Now looking back at the Makefile and:

-SUBST_VARS = ARCH

is not needed because bsd.port.mk already has ARCH in SUBST_VARS.

Best,
-Kurt

> cheers,
> Sebastian
> 
> On Sat, Sep 19, 2026 at 10:07 AM Sebastian Reitenbach <sebastia@l00-bugdead-prods.de> wrote:
> Hi,
> 
> this could also go under archivers, if preferred.
> 
> 7-Zip-JBinding is a free cross-platform java binding of 7-Zip free
> compress/decompress library.
> 
> this is the fork from sleuthkit, as they have some specific patches, that 
> sleuthkit/autopsy needs.
> 
> testing, feedback of any sort welcome.
> 
> cheers,
> Sebastian
> 
> -- 
> https://buzzdeee.reitenba.ch
> 
> 
> -- 
> https://buzzdeee.reitenba.ch<sevenzipjbinding.tar.gz>