From: Kurt Miller Subject: Re: UPDATE: add -java subpackage to sysutils/sleuthkit To: Sebastian Reitenbach Cc: ports , sthen@openbsd.org, kurt@openbsd.org Date: Thu, 8 Oct 2026 00:22:43 +0000 On Oct 7, 2026, at 8:15 PM, Kurt Miller wrote: > > On Oct 2, 2026, at 4:01 PM, Sebastian Reitenbach wrote: >> >> This updated version, without SUBPACKAGE, but like the others, installing *jars in ${MODJAVA_SHARE_DIR}/classes >> >> any testing, feedback etc. welcome. >> > > Two minor observations reviewing the Makefile. This > needs a REVISION = 0 line. The java bindings readme: > https://github.com/sleuthkit/sleuthkit/blob/develop-4.1x/bindings/java/README.txt > says its jdk 17+. MODJAVA_VER should probably be 17+ I hit send too soon. I see the jni shared lib is being installed in do-install: but the README.txt I linked above states it is embedded in the jar file, similar to other java ports providing an jni native interface. I suspect you don’t need to install the lib/libtsk_jni.* files at all. >> cheers, >> Sebastian >> >> On Sat, Sep 19, 2026 at 10:09 PM Sebastian Reitenbach wrote: >> Hi, >> >> >> >> On Sat, Sep 19, 2026 at 9:42 PM Stuart Henderson wrote: >> >> >> iirc this can bappen if you work on a copy of the port in mystuff >> rather than the main dir (or maybe if you work in the main dir >> but have an older one in mystuff) >> >> >> yeah, I am indeed working under mystuff, but have sysutils/sleuthkit deleted. >> >> In any case, I dropped the SUBPACKAGE, and I have incorporated all your suggestions. >> Getting the paths stripped was the most entertaining, didn't know about the {} feature. >> Finally I found seamonkey port, looking at that helped. >> >> Besides all that, I also put all those dependencies versions into variables. That will hopefully >> make updates easier. >> >> If this looks good to you, I'll update the other related ports in the same way. >> >> cheers, >> Sebastian >> >> >> -- >> https://buzzdeee.reitenba.ch >> >> >> -- >> https://buzzdeee.reitenba.ch > >