From: Sebastian Reitenbach <sebastia@l00-bugdead-prods.de>
Subject: Re: graphics/openjfx/21: some adjustments
To: Kurt Miller <kurt@intricatesoftware.com>
Cc: -b@intricatesoftware.com, -c@intricatesoftware.com, ports@openbsd.org
Date: Wed, 14 Oct 2026 12:36:58 +0200

On Wed, Oct 14, 2026 at 12:20 AM Kurt Miller <kurt@intricatesoftware.com>
wrote:

> Hi Sebsastian,
>
> This doesn't build on i386 due to webkit failing to link with out
> of memory, so I'm adding ONLY_FOR_ARCH excluding that and removing
> the extra logic for reducing the build threads there.
>
> Since the jar files contain shared libs with dependancies that are
> not seen by lib-depends-check, they need to be manually added to
> WANTLIB so that the resulting package records the needed dependant
> libs and the associatied functionality to know if the port needs
> an newer version due to the underlying lib version changes.
>
> Lastly I noticed that files/openbsd.gradle contained "-g", "-O0"
> in the commonFlags. I'm assuming this was left over debug work
> and have removed that as well.
>
> okay?
>

yes please!

thank you,
Sebastian


>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/graphics/openjfx/21/Makefile,v
> diff -u -p -u -r1.1.1.1 Makefile
> --- Makefile    13 Oct 2026 14:16:21 -0000      1.1.1.1
> +++ Makefile    13 Oct 2026 19:25:35 -0000
> @@ -1,3 +1,5 @@
> +ONLY_FOR_ARCH =                aarch64 amd64
> +
>  COMMENT =              JavaFX/OpenJFX client toolkit
>
>  BASE_V =               21.0.11
> @@ -7,6 +9,7 @@ GH_ACCOUNT =            openjdk
>  GH_PROJECT =           jfx21u
>  GH_TAGNAME =           ${BASE_V}+${BASE_REV}
>  PKGNAME =              openjfx-${V}
> +REVISION =             0
>
>  DISTFILES =            jfx-${V}.tar.gz
>
> @@ -107,6 +110,13 @@ LIB_DEPENDS =              \
>                         audio/pulseaudio \
>                         x11/gtk+3 \
>
> +# Ingnore extra; these are from the shared libs embeded in the jars
> +WANTLIB =              ${COMPILER_LIBCXX} GL X11 Xtst Xxf86vm atk-1.0 c
> +WANTLIB +=             cairo-gobject cairo fontconfig freetype gdk-3
> +WANTLIB +=             gdk_pixbuf-2.0 gio-2.0 glib-2.0 gobject-2.0
> gthread-2.0
> +WANTLIB +=             gtk-3 harfbuzz intl m pango-1.0 pangocairo-1.0
> +WANTLIB +=             pangoft2-1.0
> +
>  # OpenJFX uses Gradle internally
>  USE_GMAKE =            Yes
>
> @@ -122,10 +132,6 @@ GRADLE_ARGS =              --no-daemon \
>                         --offline \
>                         --init-script=${WRKDIR}/init.gradle \
>                         --info
> -
> -.if ${MACHINE_ARCH} == "i386"
> -GRADLE_ARGS +=         -PNUM_COMPILE_THREADS=1
> -.endif
>
>  post-extract:
>         cp ${FILESDIR}/openbsd.gradle \
> Index: files/openbsd.gradle
> ===================================================================
> RCS file: /cvs/ports/graphics/openjfx/21/files/openbsd.gradle,v
> diff -u -p -u -r1.1.1.1 openbsd.gradle
> --- files/openbsd.gradle        13 Oct 2026 14:16:21 -0000      1.1.1.1
> +++ files/openbsd.gradle        13 Oct 2026 19:25:35 -0000
> @@ -41,7 +41,7 @@ OPENBSD.library = { name -> return (IS_S
>
>  // A set of common parameters to use for both compiling and linking
>  def commonFlags = [
> -        "-g", "-O0", "-fno-strict-aliasing", "-fPIC",
> "-fno-omit-frame-pointer", // optimization flags
> +        "-fno-strict-aliasing", "-fPIC", "-fno-omit-frame-pointer", //
> optimization flags
>          "-fstack-protector",
>          "-Wextra", "-Wall", "-Wformat-security", "-Wno-unused",
> "-Wno-parentheses"] // warning flags
>
>

-- 
https://buzzdeee.reitenba.ch