On Fri, May 03, 2024 at 12:26:15PM GMT, Johannes Thyssen Tishman wrote:
> Please find below an update for editors/vis to version 0.9. The tests
> (which are hosted separately) didn't seem to get an update, but they all
> still pass.
> 
> Cc'd maintainer.

Thank you, this seems to work so far, but "make test" fails for me.

As far as I can tell, the problem is that SHELL is /sbin/nologin
for user _pbuild. (I have PORTS_PRIVSEP=Yes in /etc/mk.conf.)
For example, the following command causes vis to correctly capitalize
the test file's content; without SHELL=/bin/sh the vis status bar
shows "Command failed" and the text in the file is not capitalized:

	doas -u _pbuild sh -c 'SHELL=/bin/sh VIS_PATH=. ../../vis commands/filter-capitalize.in'

I pasted the end of the output of "make test" below my signature.

-- 
James


gmake[2]: Entering directory '/home/pobj/vis-0.9/vis-0.9/test/sam'
/usr/local/plan9/bin/sam
vis 0.9 +curses +lua +tre
Running test ./addresses/columns with sam ... OK
Running test ./addresses/columns with vis ... OK
Running test ./addresses/first-last with sam ... OK
Running test ./addresses/first-last with vis ... OK
Running test ./addresses/lines with sam ... OK
Running test ./addresses/lines with vis ... OK
Running test ./addresses/second with sam ... OK
Running test ./addresses/second with vis ... OK
Running test ./commands/filter-capitalize with sam ... OK
Running test ./commands/filter-capitalize with vis ... FAIL
Running test ./commands/group with sam ... OK
Running test ./commands/group with vis ... OK
Running test ./commands/long-text with sam ... OK
Running test ./commands/long-text with vis ... OK
Running test ./commands/loop-lines1 with sam ... OK
Running test ./commands/loop-lines1 with vis ... OK
Running test ./commands/loop-lines2 with sam ... OK
Running test ./commands/loop-lines2 with vis ... OK
Running test ./commands/loop-lines3 with sam ... OK
Running test ./commands/loop-lines3 with vis ... OK
Running test ./commands/loop-lines4 with sam ... OK
Running test ./commands/loop-lines4 with vis ... OK
Running test ./commands/loop-lines5 with sam ... OK
Running test ./commands/loop-lines5 with vis ... OK
Running test ./commands/loop-lines6 with sam ... OK
Running test ./commands/loop-lines6 with vis ... OK
Running test ./commands/loop-lines7 with sam ... OK
Running test ./commands/loop-lines7 with vis ... OK
Running test ./commands/loop-lines8 with sam ... OK
Running test ./commands/loop-lines8 with vis ... OK
Running test ./commands/loop-lines9 with sam ... OK
Running test ./commands/loop-lines9 with vis ... OK
Running test ./commands/pipe-in with sam ... OK
Running test ./commands/pipe-in with vis ... FAIL
Running test ./commands/pipe-out with sam ... OK
Running test ./commands/pipe-out with vis ... FAIL
Running test ./commands/repeated-shell with sam ... OK
Running test ./commands/repeated-shell with vis ... FAIL
Running test ./commands/unicode-replace with sam ... OK
Running test ./commands/unicode-replace with vis ... OK
Running test ./errors/conflict with sam ... OK
Running test ./errors/conflict with vis ... OK
Running test ./errors/read with sam ... OK
Running test ./errors/read with vis ... OK
Running test ./errors/unbalanced-group with sam ... OK
Running test ./errors/unbalanced-group with vis ... OK
Running test ./examples/comment-functions with sam ... OK
Running test ./examples/comment-functions with vis ... OK
Running test ./examples/delete-empty-lines with sam ... OK
Running test ./examples/delete-empty-lines with vis ... OK
Running test ./examples/swap-words with sam ... OK
Running test ./examples/swap-words with vis ... OK
Tests ok 22/26
gmake[2]: *** [Makefile:2: test] Error 1
gmake[2]: Leaving directory '/home/pobj/vis-0.9/vis-0.9/test/sam'
gmake[1]: *** [Makefile:5: test] Error 2
gmake[1]: Leaving directory '/home/pobj/vis-0.9/vis-0.9/test'
gmake: *** [Makefile:156: test] Error 2
*** Error 2 in . (/usr/ports/infrastructure/mk/bsd.port.mk:3096 '/home/pobj/vis-0.9/.test_done': @cd /home/pobj/vis-0.9/vis-0.9 && exec 3>&1...)
*** Error 2 in /usr/ports/editors/vis (/usr/ports/infrastructure/mk/bsd.port.mk:2704 'test': @lock=vis-0.9;  export _LOCKS_HELD=" vis-0.9"; ...)