Index | Thread | Search

From:
Omar Polo <op@omarpolo.com>
Subject:
Re: [Maintainer update] Add FLAVOR to emulator/minivmac
To:
Jag Talon <jag@aangat.lahat.computer>
Cc:
Stuart Henderson <stu@spacehopper.org>, "Anthony J. Bentley" <bentley@openbsd.org>, ports@openbsd.org, George Koehler <kernigh@gmail.com>
Date:
Tue, 30 Jul 2024 18:31:14 +0200

Download raw body.

Thread
On 2024/07/30 18:18:57 +0200, Omar Polo <op@omarpolo.com> wrote:
> On 2024/07/30 10:48:58 -0400, Jag Talon <jag@aangat.lahat.computer> wrote:
> > Attached is my attempt to do that, but when running `make install` it
> > seems to install minivmac-36.04 but with the binary for minivmac-ii-
> > 36.04.
> 
> This due to how make evals the variables.  You have
> 
> : # Macintosh Plus
> : MODEL =                 -m Plus
> :	
> : # Macintosh II
> : .if ${FLAVOR:Mii}
> : MODEL =                 -m II
> : SUFFIX =                -ii
> : .endif
> 
> so MODEL will always be '-m II'.

sorry, got the values swapped but I was talking trash anyway so discard
this.  using '=' in make overrides previous values, so model is set to
'-m II' iff FLAVOR is ii.

(yet, i believe using ?= or the conditionals is cleaner in these cases :P)