Index | Thread | Search

From:
Klemens Nanni <kn@openbsd.org>
Subject:
Re: devel/intellij, devel/pycharm: update to 2024.2.4, add devel/intellij-fsnotifier
To:
"Kirill A. Korinsky" <kirill@openbsd.org>, OpenBSD ports <ports@openbsd.org>, Lucas Raab <tuftedocelot@fastmail.fm>
Date:
Sun, 3 Nov 2024 12:14:50 +0000

Download raw body.

Thread
03.11.2024 12:58, Kirill A. Korinsky пишет:
> Lucas, ports@,
> 
> Here an update of devel/intellij and devel/pycharm to 2024.2.4.
> 
> I don't use pycharm and did only basic testing. Anyway, I use Intellij time
> to time and it works fine with Scala and Java projects.


> Index: devel/intellij/Makefile
> ===================================================================
> RCS file: /home/cvs/ports/devel/intellij/Makefile,v
> diff -u -p -r1.99 Makefile
> --- devel/intellij/Makefile	8 Sep 2024 02:15:54 -0000	1.99
> +++ devel/intellij/Makefile	3 Nov 2024 09:19:35 -0000
> @@ -1,6 +1,6 @@
>  COMMENT=		IntelliJ IDEA Java IDE
>  
> -V=			2024.2.1
> +V=			2024.2.4
>  DISTNAME=		ideaIC-${V}
>  PKGNAME=		intellij-${V}
>  CATEGORIES=		devel
> @@ -19,11 +19,12 @@ MODJAVA_VER=		17
>  BUILD_DEPENDS=		${MODJAVA_RUN_DEPENDS}
>  
>  RUN_DEPENDS=		devel/desktop-file-utils \
> +			devel/intellij-fsnotifier \
>  			java/javaPathHelper
>  
>  NO_TEST=		Yes
>  
> -WRKDIST=		${WRKDIR}/idea-IC-242.21829.142
> +WRKDIST=		${WRKDIR}/idea-IC-242.23726.103
>  IJ=			${PREFIX}/intellij
>  
>  # If NO_BUILD is set, JAVA_HOME doesn't get defined. So do
> @@ -56,5 +57,7 @@ do-install:
>  	@ln -s ${TRUEPREFIX}/bin/idea-lightedit \
>  		${PREFIX}/bin/intellij-lightedit
>  	${INSTALL_MAN} ${FILESDIR}/idea.1 ${PREFIX}/man/man1
> +
> +	@echo "idea.filewatcher.executable.path=${LOCALBASE}/bin/intellij-fsnotifier" >> ${IJ}/bin/idea.properties

Empty lines in targets look off, I don't think we do that.

> Index: devel/intellij/pkg/PLIST
> ===================================================================
> RCS file: /home/cvs/ports/devel/intellij/pkg/PLIST,v
> diff -u -p -r1.69 PLIST
> --- devel/intellij/pkg/PLIST	8 Sep 2024 02:15:54 -0000	1.69
> +++ devel/intellij/pkg/PLIST	3 Nov 2024 09:28:19 -0000
> @@ -32,7 +32,7 @@ intellij/lib/annotations.jar
>  intellij/lib/app-client.jar
>  intellij/lib/app.jar
>  intellij/lib/bouncy-castle.jar
> -intellij/lib/build-marker-IC-242.21829.142
> +intellij/lib/build-marker-IC-242.23726.103

How about something like this to avoid PLIST churn on every update?

SOME_DIST_VER =	242.23726.103
SUBST_VARS +=	SOME_DIST_VER

intellij/lib/build-marker-IC-${SOME_DIST_VER}

>  intellij/lib/cds/
>  intellij/lib/cds/classesLogAgent.jar
>  intellij/lib/external-system-rt.jar


Same for pycharm.  Just ideas, though.