On Sun, 03 Nov 2024 13:14:50 +0100,
Klemens Nanni <kn@openbsd.org> wrote:
>
> 03.11.2024 12:58, Kirill A. Korinsky пишет:
> > @@ -56,5 +57,7 @@ do-install:
> >  	@ln -s ${TRUEPREFIX}/bin/idea-lightedit \
> >  		${PREFIX}/bin/intellij-lightedit
> >  	${INSTALL_MAN} ${FILESDIR}/idea.1 ${PREFIX}/man/man1
> > +
> > +	@echo "idea.filewatcher.executable.path=${LOCALBASE}/bin/intellij-fsnotifier" >> ${IJ}/bin/idea.properties
>
> Empty lines in targets look off, I don't think we do that.
>

A few lines above that, there is also an empty line.

> > Index: devel/intellij/pkg/PLIST
> > ===================================================================
> > RCS file: /home/cvs/ports/devel/intellij/pkg/PLIST,v
> > diff -u -p -r1.69 PLIST
> > --- devel/intellij/pkg/PLIST	8 Sep 2024 02:15:54 -0000	1.69
> > +++ devel/intellij/pkg/PLIST	3 Nov 2024 09:28:19 -0000
> > @@ -32,7 +32,7 @@ intellij/lib/annotations.jar
> >  intellij/lib/app-client.jar
> >  intellij/lib/app.jar
> >  intellij/lib/bouncy-castle.jar
> > -intellij/lib/build-marker-IC-242.21829.142
> > +intellij/lib/build-marker-IC-242.23726.103
>
> How about something like this to avoid PLIST churn on every update?
>
> SOME_DIST_VER =	242.23726.103
> SUBST_VARS +=	SOME_DIST_VER
>
> intellij/lib/build-marker-IC-${SOME_DIST_VER}
>

Cleaner, indeed.

> >  intellij/lib/cds/
> >  intellij/lib/cds/classesLogAgent.jar
> >  intellij/lib/external-system-rt.jar
>
>
> Same for pycharm.  Just ideas, though.

Let see that Lucas things about it.

--
wbr, Kirill