On 2024/11/18 18:17, Kirill A. Korinsky wrote:
> ports@, Volker,
> 
> To make using of net/ejabberd better, we need a support of ODBC at erlang.
> 
> Here a diff which enables ODBC support, and new port databases/unixodbc
> which is required by erlang. To avoid conflict with databases/iodbc I
> installed headers into include/unixodbc.

This needs some thought / checking of logs, other ports are likely to
pick up unixODBC if present during build. (also IIRC some other ports
required patching etc to use iodbc in the first place and are probably
happier with unixODBC..)

: @man man/man7/unixODBC.7
: @sample ${SYSCONFDIR}/ODBCDataSources

that seems wrong, you're @sample'ing the manpage into ${SYSCONFDIR}/ODBCDataSources

: share/examples/unixodbc/
: share/examples/unixodbc/odbc.ini
: @sample ${SYSCONFDIR}/odbc.ini
: share/examples/unixodbc/odbcinst.ini
: @sample ${SYSCONFDIR}/odbcinst.ini

possibly slightly confusing to have those direct in /etc but the
headers in a subdir, and the other way round for iodbc, I think
${SYSCONFDIR}/unixodbc or ${SYSCONFDIR}/unixODBC might be better.

> -WANTLIB-main =	${WANTLIB} c crypto kvm curses util z
> +WANTLIB-main =	${WANTLIB} c crypto curses kvm odbc util z

the shared library uses curses? yeuuw.