Index | Thread | Search

From:
Omar Polo <op@omarpolo.com>
Subject:
Re: NEW: sysutils/kitd
To:
Sebastien Marie <semarie@kapouay.eu.org>
Cc:
Lydia Sobot <chilledfrogs@disroot.org>, ports@openbsd.org
Date:
Wed, 20 Nov 2024 08:41:24 +0100

Download raw body.

Thread
On 2024/11/16 16:54:46 +0100, Sebastien Marie <semarie@kapouay.eu.org> wrote:
> Lydia Sobot <chilledfrogs@disroot.org> writes:
> 
> >>could you send a tarball (tgz) of the directory, instead of a shell script
> >>to execute ?
> > Attached
> 
> Thanks, sorry for the delay.
> 
> I am fine with it, so ok semarie@ for importing it.
> 
> Could someone else could review it, please ?

haven't run-tested it, but some nits on the port:

 - spacing in the makefile coudl be improved
 - we maintain rc scripts in the ports tree even if upstream provides
   one

So here's an updated tarball with a slightly reformatted makefile and
the rc file moved under pkg/.

it's ok op@ to import if you want.  my remark about automatically
restarting this still applies, but we probably have worst stuff in the
ports tree already ;-)

--- Makefile.orig	Wed Nov 20 08:30:38 2024
+++ Makefile	Wed Nov 20 08:30:52 2024
@@ -5,18 +5,18 @@
 
 HOMEPAGE =	https://git.causal.agency/kitd/about/
 
-MAINTAINER =		Lydia Sobot <chilledfrogs@disroot.org>
+MAINTAINER =	Lydia Sobot <chilledfrogs@disroot.org>
 
 # AGPLv3+
 PERMIT_PACKAGE =	Yes
 
 # uses pledge()
-WANTLIB =		c
+WANTLIB = c
 
 SITES =		https://git.causal.agency/kitd/snapshot/
 
-FAKE_FLAGS =		PREFIX=${PREFIX}
+FAKE_FLAGS =	PREFIX=${PREFIX}
 
-NO_TEST =		Yes
+NO_TEST =	Yes
 
 .include <bsd.port.mk>