Index | Thread | Search

From:
Sebastien Marie <semarie@kapouay.eu.org>
Subject:
Re: NEW: sysutils/kitd
To:
Omar Polo <op@omarpolo.com>
Cc:
Lydia Sobot <chilledfrogs@disroot.org>, ports@openbsd.org
Date:
Sat, 23 Nov 2024 11:12:59 +0100

Download raw body.

Thread
Omar Polo <op@omarpolo.com> writes:

> On 2024/11/16 16:54:46 +0100, Sebastien Marie <semarie@kapouay.eu.org> wrote:
>> Lydia Sobot <chilledfrogs@disroot.org> writes:
>> 
>> >>could you send a tarball (tgz) of the directory, instead of a shell script
>> >>to execute ?
>> > Attached
>> 
>> Thanks, sorry for the delay.
>> 
>> I am fine with it, so ok semarie@ for importing it.
>> 
>> Could someone else could review it, please ?
>
> haven't run-tested it, but some nits on the port:
>
>  - spacing in the makefile coudl be improved
>  - we maintain rc scripts in the ports tree even if upstream provides
>    one
>
> So here's an updated tarball with a slightly reformatted makefile and
> the rc file moved under pkg/.
>
> it's ok op@ to import if you want.  my remark about automatically
> restarting this still applies, but we probably have worst stuff in the
> ports tree already ;-)

Thanks. I imported it with your changes.
-- 
Sebastien Marie