On 2025/06/21 04:49, Brad Smith wrote:
> On 2025-06-20 1:17 p.m., Jeremie Courreges-Anglas wrote:
> > On Fri, Jun 20, 2025 at 01:25:11AM -0400, Brad Smith wrote:
> > > Here is a diff for numpy that backports patches to enable CPU feature
> > > detection via elf_aux_info() on ARM, PowerPC64, and RISC-V 64.
> > PLEASE, Brad, tell us what you tested and what you didn't test when
> > you propose patches, especially arch-dependent ones.
> > This still builds on riscv64.
> > 
> > It shouldn't matter much, but I'd prefer that you initialize 'hwcap'
> > to zero and/or add error checking around elf_aux_info().
> 
> 
> I have build tested and ran 'make test' on both arm64 and riscv64. Nothing
> changes about riscv64.
> 
> arm64 -- M1
> 
> before:
> = 97 failed, 44699 passed, 345 skipped, 2815 deselected, 33 xfailed, 4
> xpassed, 65 warnings in 525.39s (0:08:45) =
> 
> after:
> = 97 failed, 44699 passed, 345 skipped, 2815 deselected, 33 xfailed, 4
> xpassed, 65 warnings in 509.20s (0:08:29) =

so about 3%, though preaumably better in certain specific cases,
seems worthwhile.

> I'll see about zero initializing hwcap.
>