Le Mon, Apr 20, 2026 at 03:23:00PM +0100, Leah Rowe a écrit :
> 
> I once again have a new tarball. See attached. From branch "submit4":
> 
> it contains this change, relative to the previous tarball:
> 
> https://codeberg.org/vimuser/librewolf-openbsd-port/commit/c818d44d36ab10ace1834fe48f6e3d088bdaf56a
> 
> this tidies up the Makefile. a lot of the logic was very messy in my opinion
> (inherited from the ff port). i generalised some strings, double-quoted a
> few strings also (ff port doesn't) specifically where WRKDIR is used, and
> made everything be 79 chars or less, per line. much cleaner to read.

that's your personal preference, but this'll make it harder to diff
Makefiles :)

> i inttend, in a further submission, to instead do away with the mozconfig
> and rely solely on the openbsd ports system. if i do this, then i will be
> able to make the logic be pretty much identical again to the firefox port.

one thing you can eventually try to get away with the mozconfig is
generating it from pre-configure using CONFIGURE_ARGS, but putting the
pre-configure target **after** including bsd.port.mk, which would
evaluate the args from modules etc.

eg set your CONFIGURE_ARGS, and at the bottom of the Makefile:

 .include <bsd.port.mk>
post-configure:
	# XXX copy the mozconfig header/static lines
.for a in ${CONFIGURE_ARGS}
	echo "ac_add_options ${a}" >> ${MOZCONFIG}
.endfor

this might work, or not, is totally untested, and might attract dragons :)

Landry