Index | Thread | Search

From:
Stuart Henderson <stu@spacehopper.org>
Subject:
Re: UPDATE: textproc/latexmk
To:
danterobinson@tuta.io
Cc:
Ports <ports@openbsd.org>
Date:
Fri, 14 Jun 2024 10:12:01 +0100

Download raw body.

Thread
On 2024/06/14 02:15, danterobinson@tuta.io wrote:
> Please let me know if this is the right format to use when sending
> in a patch, thank you!

It's mangled - tabs have been replaced by spaces. Some web-based mail
clients make it quite difficult or sometimes impossible to cleanly
include a patch.

You might hace better luck saving the diff to a file and including as an
attachment. That is not the preferred format (inline plaintext diff
direct in an email) but it's better than mangled diffs.

Other comments:

> --- Makefile.old Thu Jun 13 20:07:35 2024
> +++ Makefile Thu Jun 13 10:50:35 2024

Would be better to use "cvs diff" (if you fetched your ports tree via 
cvs) or "git diff" (if using the experimental git mirror).

> @@ -1,12 +1,12 @@
> COMMENT= LaTeX documents output generation automation tool
>  
> -DISTNAME= latexmk-452c
> +DISTNAME= latexmk-485
> EXTRACT_SUFX= .zip
> REVISION= 0

REVISION should be removed on version updates.

> -HOMEPAGE= http://www.phys.psu.edu/~collins/software/latexmk-jcc/
> +HOMEPAGE= http://www.cantab.net/users/johncollins/latexmk/

That can use https.

The patch should be regenerated too. Use "make patch" and then "make
update-patches".